https://bugzilla.redhat.com/show_bug.cgi?id=1770162 --- Comment #6 from Anna Khaitovich <akhaitov@xxxxxxxxxx> --- (In reply to Jerry James from comment #5) > 1. This is not really an issue. I just wanted to point out that you can use > this URL to get a source tarball with a name in it: > > Source0: %{url}/archive/v%{version}/%{pypi_name}-%{version}.tar.gz > > See https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags. I tried to use the URL you suggested, but the tarball which is accessible by that URL has different contents - it has no tests, so I decided to go with the one that's been used in .spec > 2. The License file must be included with the %license macro. Add this to > the > %files section: > > %license COPYING.LESSER > > The question in my mind is whether it should be: > > %license COPYING COPYING.LESSER > > Why did upstream include a copy of the GPL in COPYING if the project is > licensed under the LGPL? Is there something in the archive that is > licensed with the GPL? I'm not sure why, but since I didn't find any source files that'd be licensed under GPL, I decided to not include COPYING file. LGPL license (COPYING.LESSER) has been included. > 3. This part of %prep is not necessary: > > # Remove bundled egg-info > rm -rf %{pypi_name}.egg-info > This should be removed now. > 4. These manually specified dependencies: > > Requires: python3dist(typing-extensions) < 4.0 > Requires: python3dist(typing-extensions) >= 3.6 > Requires: python3dist(typing-inspect) >= 0.3.1 > > are redundant with the automatically generated dependencies; see the > Requires > section below. Note the duplication. You can remove the Requires lines > from > your spec file. This should also be removed. New URLs: Spec: https://copr-be.cloud.fedoraproject.org/results/akhaitov/python-molten/fedora-rawhide-x86_64/01120554-python-molten/python-molten.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/akhaitov/python-molten/fedora-rawhide-x86_64/01120554-python-molten/python-molten-0.7.4-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
