[Bug 1773467] Review Request: avocado-vt - A avocado plugin for virtualization related tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1773467



--- Comment #5 from Richard W.M. Jones <rjones@xxxxxxxxxx> ---
Don't bother to do an update until I post the full review, but there are still
a
few small things to fix:

(1) %dir /%{_sysconfdir}/avocado and %dir /%{_sysconfdir}/avocado/conf.d

You don't need the initial "/" because %{_sysconfdir} expands to /etc, so this
expands to //etc/avocado

(2) Remove Group

(3) dont' -> don't in comment

(4) You can completely remove with_python3 as well.  At the moment if the RPM
isn't
built on Fedora 31 / RHEL 8 then nothing gets built (notice that %build will be
completely
empty unless with_python3 == 1).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux