https://bugzilla.redhat.com/show_bug.cgi?id=1776513 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |ppisar@xxxxxxxxxx Flags| |fedora-review? Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-256: 260e252f7367228c9b4e43ef50c0becb04c4781de660577b3086cc106c0028c0) is original. Ok. Summary verified from lib/XString.pm. Ok. Description verified from lib/XString.pm. Ok. License verified from lib/XString.pm, t/00-load.t, t/cstring.t, Makefile.PL, XString.xs, LICENSE, and README. Ok. TODO: Please constrain 'BuildRequires: perl(ExtUtils::MakeMaker)' with '>= 6.76' due to the use of 'NO_PACKLIST=1 NO_PERLLOCAL=1'. FIX: Build-require 'findutils' (perl-XString.spec:47). TODO: Remove '>= 0.88' constrain from 'BuildRequires: perl(Test::More)' because it's needed only for author tests that the spec file does not perform. FIX: Either build-require 'perl(CPAN::Meta::Prereqs)' (t/00-report-prereqs.t:29) or do not build-require 'perl(CPAN::Meta)'. They are needed both for the optional tests. FIX: Do not build-require unused 'perl(Test2::Bundle::Extended)', 'perl(Test2::Plugin::NoWarnings)', and 'perl(Test2::Tools::Explain)'. Note: ./examples is not interesting. All tests pass. Ok. $ rpmlint perl-XString.spec ../SRPMS/perl-XString-0.002-1.fc32.src.rpm ../RPMS/x86_64/perl-XString-* sh: /usr/bin/python2: No such file or directory perl-XString.src: W: spelling-error %description -l en_US cstring -> string, c string, striking perl-XString.src: W: spelling-error %description -l en_US perlstring -> stringer, stripling, sterling perl-XString.x86_64: W: spelling-error %description -l en_US cstring -> string, c string, striking perl-XString.x86_64: W: spelling-error %description -l en_US perlstring -> stringer, stripling, sterling 4 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-XString-0.002-1.fc32.x86_64.rpm drwxr-xr-x 2 root root 0 Nov 27 11:09 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Nov 27 11:09 /usr/lib/.build-id/ab lrwxrwxrwx 1 root root 63 Nov 27 11:09 /usr/lib/.build-id/ab/c6644baecda4e2315bebf7bb520cdc01368454 -> ../../../../usr/lib64/perl5/vendor_perl/auto/XString/XString.so -rw-r--r-- 1 root root 1448 Aug 13 19:44 /usr/lib64/perl5/vendor_perl/XString.pm drwxr-xr-x 2 root root 0 Nov 27 11:09 /usr/lib64/perl5/vendor_perl/auto/XString -rwxr-xr-x 1 root root 15736 Nov 27 11:09 /usr/lib64/perl5/vendor_perl/auto/XString/XString.so drwxr-xr-x 2 root root 0 Nov 27 11:09 /usr/share/doc/perl-XString -rw-r--r-- 1 root root 241 Aug 13 19:44 /usr/share/doc/perl-XString/Changes -rw-r--r-- 1 root root 358 Aug 13 19:44 /usr/share/doc/perl-XString/README drwxr-xr-x 2 root root 0 Nov 27 11:09 /usr/share/licenses/perl-XString -rw-r--r-- 1 root root 18346 Aug 13 19:44 /usr/share/licenses/perl-XString/LICENSE -rw-r--r-- 1 root root 1623 Nov 27 11:09 /usr/share/man/man3/XString.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-XString-0.002-1.fc32.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.30()(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 perl(:MODULE_COMPAT_5.30.1) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) FIX: Run-require 'perl(XSLoader)' (lib/XString.pm:11). This one is not autodetected because of an indentation. $ rpm -q --provides -p ../RPMS/x86_64/perl-XString-0.002-1.fc32.x86_64.rpm | sort -f | uniq -c 1 perl(XString) = 0.002 1 perl-XString = 0.002-1.fc32 1 perl-XString(x86-64) = 0.002-1.fc32 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-XString-0.002-1.fc32.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 32 (https://koji.fedoraproject.org/koji/taskinfo?taskID=39374237). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the 'FIX' items and consider fixing 'TODO' items before building this pacakge. Resolution: Pacakge APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
