[Bug 1771173] Review Request: xournalpp - Handwriting note-taking software with PDF annotation support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1771173

Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |quantum.analyst@xxxxxxxxx



--- Comment #4 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> ---
Your dynamic build requirements are not dynamic, so there's no point to adding
them on Fedora 31+.

These directories are not owned:
* /usr/share/locale/tlh_AA/LC_MESSAGES
* /usr/share/locale/tlh_AA
* /usr/share/mimelnk
* /usr/share/mimelnk/application
* /usr/share/xournalpp

Don't think the first two are valid; for mimelnk use Requires:kde-filesystem;
for xournalpp, you need to own it.

Rpmlint
-------
Checking: xournalpp-1.0.16-1.fc32.x86_64.rpm
          xournalpp-debuginfo-1.0.16-1.fc32.x86_64.rpm
          xournalpp-debugsource-1.0.16-1.fc32.x86_64.rpm
          xournalpp-1.0.16-1.fc32.src.rpm
xournalpp.x86_64: W: spelling-error %description -l en_US Xournal -> Journal
xournalpp.x86_64: W: incoherent-version-in-changelog 1.0.16.1 ['1.0.16-1.fc32',
'1.0.16-1']
xournalpp.x86_64: E: non-executable-script
/usr/share/xournalpp/ui/icons/hicolor/update-icon-cache.sh 644 /bin/bash 
xournalpp.x86_64: E: non-executable-script
/usr/share/xournalpp/ui/iconsDark/hicolor/update-icon-cache.sh 644 /bin/bash 
xournalpp.x86_64: W: no-manual-page-for-binary xournal-thumbnailer
xournalpp.x86_64: W: no-manual-page-for-binary xournalpp
xournalpp.x86_64: E: invalid-lc-messages-dir
/usr/share/locale/tlh_AA/LC_MESSAGES/xournalpp.mo
xournalpp.src: W: spelling-error %description -l en_US Xournal -> Journal
xournalpp.src:42: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line
42)
4 packages and 0 specfiles checked; 3 errors, 6 warnings.


The /usr/share/xournalpp/ui/icons/hicolor/ directory seems wrong. Shouldn't
those icons be in /usr/share/icons/hicolor? And the scripts and cache should be
left out. Possibly same with the pixmaps directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux