Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: egoboo-data - Data files for the Egoboo RPG https://bugzilla.redhat.com/show_bug.cgi?id=322141 dan@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From dan@xxxxxxxx 2007-10-07 15:40 EST ------- Review: OK source files match upstream (used instructions from the spec file, no diff between them): 252c09320cd355e8b8e6f27a728045c638f9dc48 egoboo-data-2.4.3.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license (GPL). OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK %clean is present. OK package builds in mock (development/i386). OK rpmlint is silent. OK final provides and requires look sane. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK scriptlets are present. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. This package is APPROVED. But clarify the GPL version with upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review