[Bug 1761032] Review Request: koan - Kickstart Over A Network

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1761032



--- Comment #14 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> Version:        2.9.0
> Release:        0.2.git%{?dist}

The snapshot versioning doesn't match our guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

Mainly, a short commit hash isn't present to identify what it was built from.


> %package -n python%{python3_pkgversion}-koan
> Summary:        koan python%{python3_pkgversion} module
> # Uses distutil so no automatic dependencies

Koan uses setuptools as of 18df5d4f742d69c8b7343adfed0ebc795f581842, so you can
rebase to that commit and drop all manually specified Python dependencies.

You'll need to add a "BuildRequires: python3dist(setuptools)" dependency.

> %setup -q -n %{name}-%{commit}

Couldn't you use "%autosetup -n %{name}-%{commit}" instead?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux