https://bugzilla.redhat.com/show_bug.cgi?id=1764813 Sergio Monteiro Basto <sergio@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |sergio@xxxxxxxxxx --- Comment #3 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> --- Hello , I take this review - BuildRequires: gcc , is not needed we already got gcc-c++ - no need to Obsolete apt-transport-curl-https and apt-transport-curl-https, we never had these packages. Provides can eventually be useful but I'd put it in spec. - non-standard-uid and non-standard-gid _apt , I suggest use apt - IMHO I'd remove devel-doc and put all in doc . please add in %install install -d %{buildroot}%{_sysconfdir}/apt/{apt.conf,preferences,sources.list,trusted.gpg}.d install -m644 doc/examples/apt.conf %{buildroot}%{_sysconfdir}/apt/ install -m644 %{_target_platform}/vendor/sources.list %{buildroot}%{_sysconfdir}/apt/sources.list install -d %{buildroot}%{_sysconfdir}/logrotate.d cat > %{buildroot}%{_sysconfdir}/logrotate.d/apt <<EOF /var/log/apt/term.log { rotate 12 monthly compress missingok notifempty } /var/log/apt/history.log { rotate 12 monthly compress missingok notifempty } EOF in %files %dir %{_sysconfdir}/apt/apt.conf.d %dir %{_sysconfdir}/apt/preferences.d %dir %{_sysconfdir}/apt/sources.list.d %dir %{_sysconfdir}/apt/trusted.gpg.d %config(noreplace) %{_sysconfdir}/apt/apt.conf %config(noreplace) %{_sysconfdir}/apt/sources.list %config(noreplace) %{_sysconfdir}/logrotate.d/apt - Note: warning: File listed twice: /usr/share/doc/apt , I notice that we have "%doc %{_docdir}/%{name}" no need use %doc tag , %doc is to copy from BUILD to BUILDROOT or maybe you want use %docdir ... The following I need to recheck tomorrow : [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/dpkg [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/libexec/dpkg/methods, /usr/libexec/dpkg These are all minor details , most important is user _apt. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
