https://bugzilla.redhat.com/show_bug.cgi?id=1767994 Dinesh Prasanth <dmoluguw@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmoluguw@xxxxxxxxxx --- Comment #1 from Dinesh Prasanth <dmoluguw@xxxxxxxxxx> --- Thanks Fabio, for submitting the review request! 1. Looks like this package uses the `maven-model` which is deprecated 2. The "Package does not own files or directories owned by other packages" kind of didn't make sense to me For now, I'll wait for #1 issue to be resolved before I can APPROVE the package == Original Ouptut from fedora-review == This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks (This plugin doesn't exist anymore.) - Package must not depend on deprecated() packages. Note: maven-model is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/templating- maven-plugin(locale,, to, set, Failed, C, defaulting), /usr/share/java/templating-maven-plugin(locale,, to, set, Failed, C, defaulting), /usr/share/licenses/templating-maven-plugin(locale,, to, set, Failed, C, defaulting), /usr/share/maven-poms/templating-maven- plugin(locale,, to, set, Failed, C, defaulting), /usr/share/doc/templating-maven-plugin-javadoc(locale,, to, set, Failed, C, defaulting), /usr/share/javadoc/templating-maven- plugin(locale,, to, set, Failed, C, defaulting), /usr/share/javadoc/templating-maven-plugin/org(locale,, to, set, Failed, C, defaulting), /usr/share/javadoc/templating-maven- plugin/org/codehaus(locale,, to, set, Failed, C, defaulting), /usr/share/javadoc/templating-maven-plugin/org/codehaus/mojo(locale,, to, set, Failed, C, defaulting), /usr/share/javadoc/templating-maven- plugin/org/codehaus/mojo/templating(locale,, to, set, Failed, C, defaulting), /usr/share/javadoc/templating-maven- plugin/org/codehaus/mojo/templating/class-use(locale,, to, set, Failed, C, defaulting), /usr/share/licenses/templating-maven-plugin- javadoc(locale,, to, set, Failed, C, defaulting) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [-]: Bundled jar/class files should be removed before build Note: Can't find any BUILD directory (--prebuilt option?) ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) (This test was marked "FAIL" by fedora-review. However, the original Spec file is the same as spec file inside SRPM. Marking it as passed ) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: templating-maven-plugin-1.0.0-1.fc32.noarch.rpm templating-maven-plugin-javadoc-1.0.0-1.fc32.noarch.rpm templating-maven-plugin-1.0.0-1.fc32.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). templating-maven-plugin.noarch: W: invalid-url URL: https://github.com/mojohaus/templating-maven-plugin <urlopen error [Errno -2] Name or service not known> templating-maven-plugin-javadoc.noarch: W: invalid-url URL: https://github.com/mojohaus/templating-maven-plugin <urlopen error [Errno -2] Name or service not known> 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/mojohaus/templating-maven-plugin/archive/templating-maven-plugin-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 9c706d35fb99336f9735cf9b2a39da74fc9485541e19362aa9724dda65f40975 CHECKSUM(SHA256) upstream package : 9c706d35fb99336f9735cf9b2a39da74fc9485541e19362aa9724dda65f40975 Requires -------- templating-maven-plugin (rpmlib, GLIBC filtered): java-headless javapackages-filesystem mvn(org.apache.maven.shared:maven-filtering) mvn(org.apache.maven:maven-artifact:2.2.1) mvn(org.apache.maven:maven-core) mvn(org.apache.maven:maven-model:2.2.1) mvn(org.apache.maven:maven-plugin-api) mvn(org.apache.maven:maven-project) mvn(org.codehaus.plexus:plexus-interpolation) mvn(org.codehaus.plexus:plexus-utils) mvn(org.sonatype.plexus:plexus-build-api) templating-maven-plugin-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem Provides -------- templating-maven-plugin: mvn(org.codehaus.mojo:templating-maven-plugin) mvn(org.codehaus.mojo:templating-maven-plugin:pom:) templating-maven-plugin templating-maven-plugin-javadoc: templating-maven-plugin-javadoc Diff spec file in url and in SRPM --------------------------------- --- /home/dmoluguw/vmworkspace/packages/templating-maven-plugins/Fedora/1767994-templating-maven-plugin/srpm/templating-maven-plugin.spec 2019-11-11 17:29:46.023114735 -0500 +++ /home/dmoluguw/vmworkspace/packages/templating-maven-plugins/Fedora/1767994-templating-maven-plugin/srpm-unpacked/templating-maven-plugin.spec 2019-10-26 14:05:44.000000000 -0400 @@ -13,4 +13,6 @@ BuildRequires: mvn(junit:junit) BuildRequires: mvn(org.apache.maven.plugin-tools:maven-plugin-annotations) +# xmvn-builddep misses maven-clean-plugin since it's only an internal dep +BuildRequires: mvn(org.apache.maven.plugins:maven-clean-plugin) BuildRequires: mvn(org.apache.maven.plugins:maven-invoker-plugin) BuildRequires: mvn(org.apache.maven.plugins:maven-plugin-plugin) @@ -28,7 +30,4 @@ BuildRequires: mvn(org.sonatype.plexus:plexus-build-api) -# xmvn-builddep misses maven-clean-plugin (internally used by the test suite) -BuildRequires: mvn(org.apache.maven.plugins:maven-clean-plugin) - %description The templating maven plugin handles copying files from a source to a Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1767994 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Java, Shell-api, Generic Disabled plugins: SugarActivity, Ocaml, C/C++, Haskell, PHP, R, Python, Perl, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
