https://bugzilla.redhat.com/show_bug.cgi?id=1765728 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review, Ankur. (In reply to Ankur Sinha (FranciscoD) from comment #1) > Looks good. Minor issues, but not blockers: XXX APPROVED XXX > > - Cosmetic: Maybe worth adding this sentence to the description: "FinInG is a > GAP package for computation in Finite Incidence Geometry developed by John > Bamberg, Anton Betten, Philippe Cara, Jan De Beule, Michel Lavrauw and Max > Neunhoeffer." It clarifies what FinInG stands for (and gives credit to the > authors---this particular bit is optional). Okay, that's a good idea. I will add it. > - Please consider asking upstream to include a LICENSE file. I will do this, also. > - gap-pkg-fining-doc.noarch: W: only-non-binary-in-usr-lib > ^ > %{_gap_dir} is /usr/lib/gap, right? Is there a /usr/share/gap variant for > noarch bits? I expect not? There is not. When gap 4.11 is released, I plan to do an overhaul of the GAP ecosystem. It will include creating both %{_libdir}/gap for packages with binary bits and %{_datadir}/gap for packages without. It's going to take a little bit of work, but I think it should be doable. Right now, though, everything has to go into the same root directory, hence /usr/lib/gap. --- Comment #3 from Gwyn Ciesla <gwync@xxxxxxxxxxxxxx> --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-fining -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
