Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qtiplot - Data Analysis and Scientific Plotting https://bugzilla.redhat.com/show_bug.cgi?id=240373 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-10-07 03:45 EST ------- Created an attachment (id=218591) --> (https://bugzilla.redhat.com/attachment.cgi?id=218591&action=view) rpmlint result for qtiplot 0.9-5 !. First for rpmlint issue: Please check your rpms by rpmlint for review. You can check many items by using rpmlint for - binary rpms - srpms - and for installed rpms. rpmlint results are attached. * devel-file-in-non-devel-package - Please check if symlinks %{_libdir}/lib*.so (not lib*.so.*) are really needed. * no-cleaning-of-buildroot %install - %install section must clean up %buildroot first. * mixed-use-of-spaces-and-tabs - Please check what this means by "$ rpmlint -I mixed-use-of-spaces-and-tabs". * wrong-script-end-of-line-encoding - This means that this file has windows-like end-of-line encoding. Fix this by "sed -i -e 's|\r||' <file>" or dos2unix. * spurious-executable-perm - Fix the permission (usually should be 0644) * undefined-non-weak-symbol - /usr/lib/libfitRational1.so.1.0.0 has undefined non-weak symbol. ----------------------------------------------------- $ ldd -r /usr/lib/libfitRational1.so.1.0.0 > /dev/null undefined symbol: gsl_matrix_set (/usr/lib/libfitRational1.so.1.0.0) undefined symbol: gsl_vector_set (/usr/lib/libfitRational1.so.1.0.0) undefined symbol: gsl_vector_get (/usr/lib/libfitRational1.so.1.0.0) ----------------------------------------------------- This can be ignored because this package does not provide -devel subpackage, however for this package this can be fixed by linking against libgsl.so. B. The rest issues: * Redundant BuildRequires - Remove redundant BuildRequires and reduce them. For example, PyQt4-devel Requires qt4-devel and sip-devel, so "BuildRequires: qt4-devel sip-devel" is not needed. (Please also check the rest BuildRequires!) - By the way I prefer to write one BuildRequires per one line because it is easier to read and also makes it easier to find the diff when BR changes. * Parallel make - Parallel make seems okay for this package http://koji.fedoraproject.org/koji/taskinfo?taskID=185870 * Desktop vendor prefix - Usually we make desktop file have vendor prefix "fedora". (check the subsection "desktop-file-install usage" of http://fedoraproject.org/wiki/Packaging/Guidelines ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review