https://bugzilla.redhat.com/show_bug.cgi?id=1770898 Petr Šplíchal <psplicha@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #4 from Petr Šplíchal <psplicha@xxxxxxxxxx> --- Thanks for the quick feedback. (In reply to Miro Hrončok from comment #2) > Shoulds (highly recommended): > > 1. Group: is deprecated and SHOULD NOT be used. Removed. > 2. The software uses setuptools, but the build dependency is not > declared. It is transitively pulled in, but that should not be > relied upon. Fixed. > Suggestions (totally optional): > > 3. Source0 could include %{name} instead of harcoded value. Shortened. > 4. See the > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_example_python_spec_file about how to not duplicate %description > (although, here the descriptions are a bit different for no obvious reason). Thanks for the hint. (In reply to Miro Hrončok from comment #3) > Must fix: > > 5. License: LGPLv2, but the Python package metadata says "License :: OSI > Approved :: GNU Lesser General Public License v2 or later (LGPLv2+)" Fixed. > 6. The requirements on old EPELs miss six: > > Fedora: > > python3.8dist(gssapi) > python3.8dist(psycopg2) > python3.8dist(six) > > EPEL < 8: > > python36-gssapi > python36-psycopg2 I see. Thanks for catching this. > Shoulds: > > 7. The high-level interface has an integrated test suite, but > there is no %check. The test suite requires a running server and kerberos auth so it cannot be enabled during rpm build. All issues should now be fixed: https://github.com/psss/python-nitrate/commit/940b1a2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
