https://bugzilla.redhat.com/show_bug.cgi?id=1770784 --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License FIX: The license is 'GPLv2+ or Artistic' Check the section 'LICENSE AND COPYRIGHT' in the Callsite.pm Description is ok URL and Source0 are ok All tests passed BuildRequires: FIX: Please add following buil-requires: - perl(B) - t/01callsite.t:4 - perl(warnings) - t/01callsite.t:2 $ rpm -qp --requires perl-Devel-Callsite-1.0.1-1.fc32.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.30()(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 perl(base) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.30.1) 1 perl(vars) 1 perl(:VERSION) >= 5.5.0 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-Devel-Callsite-1.0.1-1.fc32.x86_64.rpm | sort | uniq -c 1 perl(Devel::Callsite) = 1.0.1 1 perl-Devel-Callsite = 1.0.1-1.fc32 1 perl-Devel-Callsite(x86-64) = 1.0.1-1.fc32 Binary provides are Ok. $ rpmlint perl-Devel-Callsite* perl-Devel-Callsite.x86_64: W: hidden-file-or-dir /usr/lib64/perl5/vendor_perl/auto/Devel/Callsite/.packlist perl-Devel-Callsite.x86_64: W: perl-temp-file /usr/lib64/perl5/vendor_perl/auto/Devel/Callsite/.packlist 2 packages and 1 specfiles checked; 0 errors, 2 warnings. FIX: Please remove packlist. The easier way to remove .packlist is used NO_PACKLIST option, which is part of perl(ExtUtils::MakeMaker) >= 6.76. perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" NO_PACKLIST=1 TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. TODO: In spec file, please consider replacing 1) perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" make %{?_smp_mflags} by perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" NO_PACKLIST=1 NO_PERLLOCAL=1 %make_build 2) make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT by %make_install These changes work on all currently supported Fedora and EPEL targets. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Resolution: Not approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
