https://bugzilla.redhat.com/show_bug.cgi?id=1767998 --- Comment #5 from Andrew Gaul <gaul@xxxxxxxx> --- > > Also, you should run the tests (https://github.com/linux-on-mac/mbpfan#run-the-tests-optional) in %check section, if possible. > > The tests are optional and might fail if the fans are running too fast. > While installing from source, it is easy to understand to it's just a false > positive, a user using DNF won't and it'll print some scary errors. > > See https://github.com/linux-on-mac/mbpfan/issues/198 I co-maintain mbpfan and prefer not running the tests. Previously we recommended this when mbpfan worked in a more manual configuration way but we are moving towards automatically detecting everything and requiring no input from the user. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
