[Bug 1770278] Review Request: vimiv-qt - An image viewer with vim-like keybindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1770278



--- Comment #6 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
- The package builds correctly on rawhide. Here's a scratch build, for example:
https://koji.fedoraproject.org/koji/taskinfo?taskID=38865749

- They aren't shared objects, they are compiled python libraries, so that
particular guidelines does not apply to them.
- The stuff in %{_datadir} are the icons, so it doesn't make sense to move them
to a subpackage.
- I removed the the documentation. We include the man page for the application,
and the docs are available online.
- I improved the description of the doc sub package to make it longer than the
summary.

The tests required pytest-bdd which is not yet in Fedora, so they can't be run
at the moment.

Spec/srpm updated in place.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux