[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1769297



--- Comment #4 from Aniket Pradhan <aniketpradhan1999@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Splitting out the -devel subpackages seems bogus. The .so file is just the
> python module.
> Also, your -devel package is not installable.
> 
> Merge the -devel package back into the python3- package.
> Those .h files can be %excluded, they are not used at runtime.

Yeah... I did that because of the header file warning. I was not sure if they
are used during the runtime. I'll exclude them if that is the case.


(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> I forgot to add:
> > %{__python3} setup.py test
> > nosetests test
> 
> Why two calls? This second line could run with the wrong python versions on
> F<32.

%{__python3} setup.py test copies some the python module (.so) file to the
source directory. It also doesn't run the tests. If I don't run this, the tests
using nose fails. Hence I had added the two statements.
Sure, you are right. I should use nosetests-3 to run the test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux