https://bugzilla.redhat.com/show_bug.cgi?id=1768447 --- Comment #6 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Thank you for very fast review! >> It is forked from MComix gtk3 branch and switch to python3. > It has been forked from the original MComix project and ported to python3. ? Well, I just copy/pasted the upstream sentence here, but I will use your sentence. > That is so complicated. I understand that it makes submitting patches upstream a > bit easier, but it also makes the package harder to contribute to for other contributors, Actually as recently I came to submit patches to the upstream more and more times, gradually I came to think that this way (i.e. cloning the upstream git to the build directory) is easier. Generating tarball can be done by just running Source1 (as I commented), so for now I will do this way. Thank you for comment anyway. > mcomix3.noarch: W: desktopfile-without-binary /usr/share/applications/mcomix3.desktop mcomix3 Umm... I did not see this warning, but after I checked the source of rpmlint, I suppose I got the reason. i.e. Once one installs (current) mcomix3 binary, this rpmlint disappears (for even binary rpm). Well, /usr/share/rpmlint/MenuXDGCheck.py says: ========================================================================= 58 binary = None 59 if cfp.has_option('Desktop Entry', 'Exec'): 60 binary = cfp.get('Desktop Entry', 'Exec').partition(' ')[0] 61 if binary: 62 found = False 63 if binary.startswith('/'): 64 found = os.path.exists(root + binary) 65 else: 66 for i in STANDARD_BIN_DIRS: 67 if os.path.exists(root + i + '/' + binary): 68 # no need to check if the binary is +x, rpmlint does it 69 # in another place 70 found = True 71 break 72 if not found: 73 printWarning( 74 pkg, 'desktopfile-without-binary', filename, binary) =========================================================================== So here I *guess* rpmlint once unpack the binary rpm, and rpmlint checks if the binary actually exists at the line 67 (here "root" is *perhaps* the unpacked directory, "i" is /usr/bin, binary is mcomix3), and actually <unpacked root>/usr/bin/mcomix3 is the symlink pointing to absolute path /usr/lib/..... which does not exist unless mcomix3 binary is actually installed. So perhaps I guess this will be fixed when changing the symlink to the relative one. I may try it once importing this package. > Hmm, maybe Provides should be added, at least for mcomix? I will do this, thank you for suggestion. Now I will proceed to the following procedure. Again thank you for review and approving this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
