Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: shorewall-common - Common files for the shorewall firewall compilers https://bugzilla.redhat.com/show_bug.cgi?id=321691 ------- Additional Comments From jonathan.underwood@xxxxxxxxx 2007-10-06 20:36 EST ------- $ rpmlint -i ../RPMS/noarch/shorewall-common-4.0.4-1.fc7.noarch.rpm shorewall-common.noarch: W: service-default-enabled /etc/rc.d/init.d/shorewall The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service. -->This one is bogus - the startup script has an empty entry for Default-Start. Removing the Default-Start entry makes the warning go away, but it is fine to have an empty one there. shorewall-common.noarch: E: subsys-not-used /etc/rc.d/init.d/shorewall While your daemon is running, you have to put a lock file in /var/lock/subsys/. To see an example, look at this directory on your machine and examine the corresponding init scripts. --> Also bogus - shorewall creates a lock file itself, there's no need for the startup script to generate one. shorewall-common.noarch: W: incoherent-init-script-name shorewall The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name. --> Also bogus - this goes away if I rename the startup script shorewall-common, which is an awkward name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review