https://bugzilla.redhat.com/show_bug.cgi?id=1768447 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > It is forked from MComix gtk3 branch and switch to python3. It has been forked from the original MComix project and ported to python3. ? > # Setup source git repository > git clone ./%{name}.git > cd %{name} > > git config user.name "%{name} Fedora maintainer" > git config user.email "%{name}-owner@xxxxxxxxxxxxxxxxx" > git checkout -b %{version}-%{release}-fedora %{gitcommit} > > # Apply patches > cat %{PATCH1} | git am > cat %{PATCH2} | git am > cat %{PATCH3} | git am > # For now apply this > cat %{PATCH4} | git am That is so complicated. I understand that it makes submitting patches upstream a bit easier, but it also makes the package harder to contribute to for other contributors, because of the complicated setup and because of the need to generate the tarball manually. Maybe it is not worth it, and the normal setup with the tarball downloaded directly from github should be used? rpmlint says: mcomix3.noarch: W: desktopfile-without-binary /usr/share/applications/mcomix3.desktop mcomix3 But /usr/bin/mcomix3 is in the package. Strange. mcomix3.noarch: W: obsolete-not-provided comix mcomix3.noarch: W: obsolete-not-provided mcomix Hmm, maybe Provides should be added, at least for mcomix? After all, people just want to upgrade and get the new package instead of the old one, most likely. + latest version (git) + package name is OK + license is acceptable for Fedora (GPLv2+) + license is specified correctly + builds and installs OK + Provides/Requires/BuildRequires look OK I had some suggestions, but they are only suggestions. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
