https://bugzilla.redhat.com/show_bug.cgi?id=1768090 --- Comment #4 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to Antonio from comment #2) > === Issues === > > - Sub-package are installed without license file except > 'opencascade-foundation' All the other packages should require the foundation package but I'll double check. > - '-Wl,--as-needed' are linker flags already included for packaging: > > $ rpm --eval %__global_ldflags > -Wl,-z,relro -Wl,--as-needed -Wl,-z,now > -specs=/usr/lib/rpm/redhat/redhat-hardened-ld > > Any reason for unsetting default linker flags? > > # Stop excessive linking that cmake projects are prone to. > export LDFLAGS="-Wl,--as-needed" This is all left over from the OCE package, I can remove it. > > - %ldconfig_scriptlets are missing. I'm pretty sure those are handled by file triggers now, no? > > - Please, remove macros in the comments. I assume you're talking about the source URL? I was of two minds on that one. Because a login is required to download the source I have to just list the source name but I wanted others to be able to piece together the download url (if it worked without a login). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
