https://bugzilla.redhat.com/show_bug.cgi?id=1767216 Martin Kutlak <mkutlak@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Martin Kutlak <mkutlak@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-colcon-cd-0.1.1-2.fc32.noarch.rpm python-colcon-cd-0.1.1-2.fc32.src.rpm python-colcon-cd.src: E: specfile-error warning: extra tokens at the end of %endif directive in line 28: %endif # __pythondist_requires 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Source checksums ---------------- https://github.com/colcon/colcon-cd/archive/0.1.1/colcon-cd-0.1.1.tar.gz : CHECKSUM(SHA256) this package : 4188a9c30541fd5bd3a9528c7ddb0cd29ed6811fc65f8e3f560e8231e81234e0 CHECKSUM(SHA256) upstream package : 4188a9c30541fd5bd3a9528c7ddb0cd29ed6811fc65f8e3f560e8231e81234e0 Requires -------- python3-colcon-cd (rpmlib, GLIBC filtered): python(abi) python3.8dist(colcon-core) python3.8dist(colcon-package-information) Provides -------- python3-colcon-cd: python-colcon-cd python3-colcon-cd python3.8dist(colcon-cd) python3dist(colcon-cd) Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -r -n python-colcon-cd-0.1.1-2.fc32.src.rpm Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Generic, Python, Shell-api Disabled plugins: Haskell, PHP, Java, SugarActivity, Ocaml, Perl, R, fonts, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH LGTM -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
