https://bugzilla.redhat.com/show_bug.cgi?id=1762673 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@xxxxxxxxxxxxxxxxxx --- Comment #7 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- Just some quick comments: - URL: https://github.com/IanHarvey/%{modname} -> I (and probably many other) prefer if the link can be copied and pasted. - Source0: https://github.com/IanHarvey/%{modname}/archive/v/%{version}.tar.gz -> Source0: https://github.com/IanHarvey/bluepy/archive/v/%{version}/%{modname}-%{version}.tar.gz - %{?python_enable_dependency_generator} -> can be removed (default for new Fedora releases) https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies - %doc docs/_build/html -> Putting the docs into a subpackage will keep the main package small. The main issue seems that the build is done with a bundled release of bluez (bluez-5.47). Fedora already ships bluez, thus that code should be used. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
