[Bug 1764175] Review Request: Elements - A C++/Python build framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1764175



--- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> ---
The upstream tarball (https://github.com/degauden/Elements/archive/5.8.tar.gz)
has md5sum 356a85aafbd37b0e39783ad4336b640a79b10a53377ab9cf5ccb5e972ff17c07. 
The tarball included in your source RPM has md5sum
b7b2d861320b61d2fb7ae0f8a9d7cedd9899803e17af668a877444912c467d46.  The Source
tag must refer to a tarball that matches the one in the package.  If you have
altered the upstream sources because upstream uses prohibited code, then please
follow the guidelines here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#when-upstream-uses-prohibited-code.
 Otherwise, please explain why the source tarballs differ.

This package creates libraries that do not have sonames.  Please talk to
upstream about that.  See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning

Use either %{buildroot} or $RPM_BUILD_ROOT, not both.  See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags

The source files have the "any later version" language, so I believe the
license should be LGPLv3+, not LGPLv3.

Something is going wrong generating the documentation.  From the build log:
error: Fatal error at line 1 column 1: unexpected end of file
error: Fatal error at line 1 column 1: error while parsing prolog

Also this.  Perhaps building PDF documentation should be disabled?

sh: latex: command not found
error: Problems running latex. Check your installation or look for typos in
_formulas.tex and check _formulas.log!
sh: dvips: command not found
error: Problems running dvips. Check your installation!

Remove all Group tags and the %clean section:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

There is a comment explaining Patch0.  Please add a comment for Patch1.  See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment

Remove this line.  The dependency on python3 is automatically generated:
Requires:      python3

Remove these lines.  They are not needed in Fedora:
Requires(post):    /sbin/ldconfig
Requires(postun):  /sbin/ldconfig
Also remove the %post and %postun scripts.  See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries

In %description, write "A C++ based" instead of "A C++ base".

Change the Requires in the devel package to these:
Requires: cmake-filesystem
Requires: %{name}%{?_isa} = %{version}-%{release}

The devel package does not need cmake itself, just the directories where the
cmake files are stored.  The addition of %{?_isa} on the second one is
explained here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_specific_dependencies

The doc subpackage should not have "Requires: %{name}-devel", as you do not
need headers installed to read documentation.  In fact, it should probably have
no Requires at all, in spite of what rpmlint has to say on the matter.

Consider replacing the body of %prep with "%autosetup -p1 -c
%{name}-%{version}".  See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_autosetup

Remove this line from all %files sections:
%defattr(-,root,root,-)
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions

Do you really need all of those %changelog entries? This package has not been
in Fedora, so this is history for some other project, probably not of interest
to Fedora.  I suggest having a single %changelog entry, with something short
like "Initial RPM".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux