[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1759940



--- Comment #22 from John Marshall <John.W.Marshall@xxxxxxxxxxxxx> ---
> According to following document, so files in %files should not be listed by using a glob.
>
>> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files
>> Shared libraries installed directly into %{_libdir} SHOULD NOT be listed in the %files section of the spec by using a glob in a way that conceals important parts of the file name (e.g. libfoo.so*), since changes to the SONAME also result in a changed file name in most cases.

These plugin files are not shared libraries, are not installed into libdir, do
not have SONAMEs, and the glob does not conceal parts that are important in the
way mentioned. So this paragraph does not apply. But you should do as you see
fit.

However there is a bug here. The htslib main package creates the
libexecdir/htslib directory so needs to package the directory itself so that it
will be deleted on uninstall. So what this really wants is

%files
%{_libexecdir}/%{name}

or equivalent.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux