https://bugzilla.redhat.com/show_bug.cgi?id=1763597 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sanjay.ankur@gmai | |l.com) | --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Could be a fedora-review thing. The spec should be correct: parses fine with `rpmspec -P ./python-graph-tool.spec` I've got fedora-review-0.7.3-1.fc31.noarch here and it seemed to go through the process and generate the review.txt template here: $ fedora-review -n python-graph-tool -p --no-build INFO: Processing local files: python-graph-tool INFO: Getting .spec and .srpm Urls from : Local files in /home/asinha/Documents/02_Code/01_others/fedora-new-packages/python-graph-tool/RPMS INFO: --> SRPM url: file:///home/asinha/Documents/02_Code/01_others/fedora-new-packages/python-graph-tool/RPMS/python-graph-tool-2.29-1.fc32.src.rpm INFO: --> Spec url: file:///home/asinha/Documents/02_Code/01_others/fedora-new-packages/python-graph-tool/RPMS/python-graph-tool.spec INFO: Using review directory: /home/asinha/Documents/02_Code/01_others/fedora-new-packages/python-graph-tool/RPMS/review-python-graph-tool WARNING: Package python-graph-tool-debuginfo-2.29-1.fc31 not built WARNING: Package python-graph-tool-debugsource-2.29-1.fc31 not built WARNING: No cache found for /home/asinha/Documents/02_Code/01_others/fedora-new-packages/python-graph-tool/RPMS/review-python-graph-tool/upstream/graph-tool-2.29.tar.bz2, downloading anyway. INFO: Downloading (Source0): https://downloads.skewed.de/graph-tool/graph-tool-2.29.tar.bz2 INFO: Running checks and generating report INFO: Active plugins: Shell-api, C/C++, Generic, Python WARNING: Illegal return from /usr/share/fedora-review/scripts/generic-large-docs.sh, code 80, output: stdout:Documentation size is 0 bytes in 0 files. stderr:files over 4GB not supported by cpio, use rpm2archive instead INFO: ExclusiveArch dependency checking disabled, enable with EXARCH flag Review template in: /home/asinha/Documents/02_Code/01_others/fedora-new-packages/python-graph-tool/RPMS/review-python-graph-tool/review.txt fedora-review is automated tool, but *YOU* are responsible for manually reviewing the results and finishing the review. Do not just copy-paste the results without understanding them. (Not entirely sure what the warning is about) The numthreads etc is a hack to try and use more threads with %make_build if we get a good builder (since there's no way to choose a good builder). I can remove that bit for the review and add it later before building if that's OK? The srpm from the koji scratch build will differ from this new srpm, though. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
