https://bugzilla.redhat.com/show_bug.cgi?id=1759883 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks good. A few issues, but not blockers. Please fix them before the import. (Please remember to add these packages to neuro-sig after import too). XXXX APPROVED XXXX Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Cosmetic: mixed use of space in tabs, please use one for consistency. - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ^ The mirrors don't seem to have the required deps yet. - if only the -doc subpackage is installed, %{_datadir}/%{name} is not owned by anything. I guess also make the -doc subpackage own it? - Please use the directory macros: %{_bindir} instead of /usr/bin etc. - There are headers in the -doc package, but I assume they're simply there for documentation? - The Requires: on the non-devel package is written differently than in the guidelines. Please double-check. - The version-release string in the changelog is incomplete (rpmlint caught it) ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages ^ Tested on the koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38473863 [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dolfin ^ When -doc is installed only, this is unowned. [x]: %build honors applicable compiler flags or justifies otherwise. ^ Verified in koji scratch build log, e.g.: https://kojipkgs.fedoraproject.org//work/tasks/3867/38473867/build.log [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). ^ Please use the directory macros [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. ^ Koji scratch build succeeds [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dolfin- devel , python3-dolfin ^ It's there, but written slightly differently. Please check. [?]: Package functions as described. ^ Not tested this out. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ^ Scratch build succeeds [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. ^ Ran on all downloaded files. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dolfin-2019.1.0.post0-1.fc32.x86_64.rpm dolfin-devel-2019.1.0.post0-1.fc32.x86_64.rpm python3-dolfin-2019.1.0.post0-1.fc32.x86_64.rpm dolfin-doc-2019.1.0.post0-1.fc32.noarch.rpm dolfin-debuginfo-2019.1.0.post0-1.fc32.x86_64.rpm dolfin-debugsource-2019.1.0.post0-1.fc32.x86_64.rpm dolfin-2019.1.0.post0-1.fc32.src.rpm dolfin.x86_64: W: incoherent-version-in-changelog 2019.1.0-1 ['2019.1.0.post0-1.fc32', '2019.1.0.post0-1'] ^ Please fix dolfin.x86_64: W: shared-lib-calls-exit /usr/lib64/libdolfin.so.2019.1.0 exit@GLIBC_2.2.5 dolfin.x86_64: W: no-manual-page-for-binary dolfin-version dolfin.x86_64: W: no-manual-page-for-binary fenics-version dolfin-devel.x86_64: W: no-documentation python3-dolfin.x86_64: E: devel-dependency dolfin-devel python3-dolfin.x86_64: W: no-documentation python3-dolfin.x86_64: W: no-manual-page-for-binary dolfin-convert python3-dolfin.x86_64: W: no-manual-page-for-binary dolfin-order python3-dolfin.x86_64: W: no-manual-page-for-binary dolfin-plot dolfin-doc.noarch: W: no-documentation dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/auto-adaptive-poisson/cpp/AdaptivePoisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/auto-adaptive-poisson/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/bcs/cpp/Poisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/bcs/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/biharmonic/cpp/Biharmonic.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/biharmonic/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/built-in-meshes/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/cahn-hilliard/cpp/CahnHilliard2D.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/cahn-hilliard/cpp/CahnHilliard2D.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/cahn-hilliard/cpp/CahnHilliard3D.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/cahn-hilliard/cpp/CahnHilliard3D.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/cahn-hilliard/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/eigenvalue/cpp/StiffnessMatrix.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/eigenvalue/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/hyperelasticity/cpp/HyperElasticity.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/hyperelasticity/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/mixed-poisson/cpp/MixedPoisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/mixed-poisson/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/navier-stokes/cpp/PressureUpdate.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/navier-stokes/cpp/TentativeVelocity.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/navier-stokes/cpp/VelocityUpdate.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/navier-stokes/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/neumann-poisson/cpp/Poisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/neumann-poisson/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/nonlinear-poisson/cpp/NonlinearPoisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/nonlinear-poisson/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/nonmatching-interpolation/cpp/P1.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/nonmatching-interpolation/cpp/P3.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/nonmatching-interpolation/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/periodic/cpp/Poisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/periodic/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/poisson/cpp/Poisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/poisson/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/singular-poisson/cpp/Poisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/singular-poisson/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/stokes-iterative/cpp/Stokes.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/stokes-iterative/cpp/StokesPreconditioner.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/stokes-iterative/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/stokes-taylor-hood/cpp/Stokes.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/stokes-taylor-hood/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/documented/subdomains/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/advection-diffusion/cpp/AdvectionDiffusion.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/advection-diffusion/cpp/Velocity.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/advection-diffusion/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/ale/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/auto-adaptive-navier-stokes/cpp/AdaptiveNavierStokes.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/auto-adaptive-navier-stokes/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/block-matrix/cpp/StiffnessMatrix.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/block-matrix/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/conditional/cpp/Conditional.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/conditional/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/contact-vi-snes/cpp/HyperElasticity.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/contact-vi-snes/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/contact-vi-tao/cpp/Elasticity.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/contact-vi-tao/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/curl-curl/cpp/CurrentDensity.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/curl-curl/cpp/EddyCurrents.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/curl-curl/cpp/P1Space.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/curl-curl/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/dg-advection-diffusion/cpp/AdvectionDiffusion.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/dg-advection-diffusion/cpp/Projection.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/dg-advection-diffusion/cpp/Velocity.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/dg-advection-diffusion/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/dg-poisson/cpp/Poisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/dg-poisson/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/elasticity/cpp/Elasticity.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/elasticity/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/elastodynamics/cpp/DG0_eps_xx.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/elastodynamics/cpp/ElastoDynamics.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/elastodynamics/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/eval/cpp/Projection.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/eval/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/extrapolation/cpp/P1.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/extrapolation/cpp/P2.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/extrapolation/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/functional/cpp/EnergyNorm.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/functional/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/gmg-poisson/cpp/Poisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/gmg-poisson/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/lift-drag/cpp/Functionals.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/lift-drag/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/mesh-quality/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/meshfunction-refinement/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/multimesh-3d/cpp/MultiMeshH10Norm.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/multimesh-3d/cpp/MultiMeshL2Norm.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/multimesh-3d/cpp/MultiMeshPoisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/multimesh-3d/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/multimesh-poisson/cpp/MultiMeshPoisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/multimesh-poisson/cpp/P1.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/multimesh-poisson/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/multimesh-stokes/cpp/MultiMeshStokes.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/multimesh-stokes/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/nonmatching-projection/cpp/P1_projection.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/nonmatching-projection/cpp/P3.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/nonmatching-projection/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/parallel-refinement/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/parameters/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/poisson-disc/cpp/PoissonDisc.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/poisson-disc/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/poisson1D-in-2D/cpp/Poisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/poisson1D-in-2D/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/poisson1D/cpp/Poisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/poisson1D/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/refinement/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/spatial-coordinates/cpp/SpatialCoordinates.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/spatial-coordinates/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/submesh/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/sym-dirichlet-bc/cpp/Poisson.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/sym-dirichlet-bc/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/time-series/cpp/main.cpp dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/waveguide/cpp/Forms.h dolfin-doc.noarch: W: devel-file-in-non-devel-package /usr/share/dolfin/demo/undocumented/waveguide/cpp/main.cpp ^ I assume these are OK. Please check. dolfin-doc.noarch: W: no-manual-page-for-binary dolfin-get-demos dolfin.src:93: W: rpm-buildroot-usage %build VERBOSE=1 CMAKE_PREFIX_PATH=%{buildroot}/usr/share/dolfin/cmake CMAKE_SKIP_INSTALL_RPATH=yes CMAKE_SKIP_RPATH=yes %py3_build dolfin.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 1) ^ Please use either spaces or tabs but not both. 7 packages and 0 specfiles checked; 1 errors, 125 warnings. Unversioned so-files -------------------- python3-dolfin: /usr/lib64/python3.8/site-packages/dolfin/cpp.cpython-38-x86_64-linux-gnu.so ^ This is OK. Source checksums ---------------- https://bitbucket.org/fenics-project/dolfin/downloads/dolfin-2019.1.0.post0.tar.gz.asc : CHECKSUM(SHA256) this package : 08b2a4c3bc42b134868a64b7917b139ef86493bfabaf45b6475202cbb96f5f18 CHECKSUM(SHA256) upstream package : 08b2a4c3bc42b134868a64b7917b139ef86493bfabaf45b6475202cbb96f5f18 https://bitbucket.org/fenics-project/dolfin/downloads/dolfin-2019.1.0.post0.tar.gz : CHECKSUM(SHA256) this package : 61abdcdb13684ba2a3ba4afb7ea6c7907aa0896a46439d3af7e8848483d4392f CHECKSUM(SHA256) upstream package : 61abdcdb13684ba2a3ba4afb7ea6c7907aa0896a46439d3af7e8848483d4392f Requires -------- dolfin (rpmlib, GLIBC filtered): /usr/bin/bash libboost_filesystem.so.1.69.0()(64bit) libboost_iostreams.so.1.69.0()(64bit) libboost_program_options.so.1.69.0()(64bit) libboost_timer.so.1.69.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libhdf5.so.103()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) dolfin-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config dolfin libdolfin.so.2019.1()(64bit) python3-dolfin (rpmlib, GLIBC filtered): /usr/bin/python3 dolfin-devel libc.so.6()(64bit) libdolfin.so.2019.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) python(abi) python3.8dist(fenics-dijitso) python3.8dist(fenics-ffc) python3.8dist(fenics-ufl) python3.8dist(numpy) python3.8dist(pkgconfig) python3.8dist(pybind11) rtld(GNU_HASH) dolfin-doc (rpmlib, GLIBC filtered): /usr/bin/bash dolfin-debuginfo (rpmlib, GLIBC filtered): dolfin-debugsource (rpmlib, GLIBC filtered): Provides -------- dolfin: dolfin dolfin(x86-64) libdolfin.so.2019.1()(64bit) dolfin-devel: dolfin-devel dolfin-devel(x86-64) pkgconfig(dolfin) python3-dolfin: python-dolfin python3-dolfin python3-dolfin(x86-64) python3.8dist(fenics-dolfin) python3dist(fenics-dolfin) dolfin-doc: dolfin-doc dolfin-debuginfo: debuginfo(build-id) dolfin-debuginfo dolfin-debuginfo(x86-64) dolfin-debugsource: dolfin-debugsource dolfin-debugsource(x86-64) Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -n dolfin -p Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Generic, Shell-api, Python, C/C++ Disabled plugins: PHP, R, fonts, Perl, Java, SugarActivity, Ocaml, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
