https://bugzilla.redhat.com/show_bug.cgi?id=1759940 John Marshall <John.W.Marshall@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(John.W.Marshall@g | |lasgow.ac.uk) | --- Comment #15 from John Marshall <John.W.Marshall@xxxxxxxxxxxxx> --- > I sent a pull-request to Fedora repository about your configure script's suggestion. > Could you review or comment below page? Thanks. > https://src.fedoraproject.org/rpms/htslib/pull-request/1 1. The plugins are loaded when libhts.so.2 is used. Hence they should be in the main package, not the -devel subpackage. 2. In %files, I suggest using %{_libexecdir}/%{name}/hfile_*.so rather than explicitly listing the three that currently exist. 3. You are building from an htslib release tarball, which already has configure built. So there is no need to run autoheader/autoconf or to build-require autoconf. >> The file format man pages (sam.5 etc) are aimed at users of tools eg >> samtools, not only at developers using the API. So IMHO they would fit >> better in the htslib-tools subpackage alongside the other manual pages. > > Currently htslib-tools sub package is for binary tools such as bgzip, htsfile > and tabix binary commands. > I am not comforable to add the file format man page files (= man5 [1]) to the htslib-tools. They are for users, not just developers, so it is not appropriate to put them in the -devel package. If you don't want to put them in the -tools package, then put them in the main package -- in fact, that's probably an even better fit as some users will fool-hardily omit to install htslib-tools. > Right now I am checking other spec file's situation for man5 files. > > * libreport.spec > main package > * libbind.spec > devel sub package That is incorrect -- libbind.spec puts the majority of its man pages in the main package. > * libpng.spec > main package So your survey of other spec files reinforces putting htslib's *.5 in the main package. John -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
