Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wmnd - A network monitoring dock app for WindowMaker https://bugzilla.redhat.com/show_bug.cgi?id=310631 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-10-05 16:32 EST ------- The source should be an url allowing to download the tarball. In that case, something along: http://www.thregr.org/~wavexx/software/wmnd/releases/wmnd-%{version}.tar.gz At first sight the buildroot doesn't seems to be in the preferred ones. This package depends on trend, that doesn't seems to be in fedora http://www.thregr.org/~wavexx/software/trend/ it would be nice to package it too. The CFLAGS are already set by %configure. You can use make install DESTDIR=... if you go that way, you could add INSTALL='install -p' on the make install command line to keep timestamp. And you'll have to remove the example config file that is better shipped as doc as you do. make %{?_smp_mflags} should be used unless it is broken. I suggest that you install the rpmdevtools package and have a look at the template in /etc/rpmdevtools/spectemplate-minimal.spec Also some of the issue I post are explained in the guidelines http://fedoraproject.org/wiki/Packaging/Guidelines the package can use the snmp libs to have more functionalities. The README.Fedora doesn't seems to be useful to me, the dockapp will work out of the box as expected. It would be nice to ask the copyright holder of drivers.c to add a proper license notice. Not a blocker since it is clearly intended to be GPL. The license seems to me to be GPLv2+ and not GPLv2. rpmlint: wmnd.i386: W: no-version-in-last-changelog Suggestions: use %{_mandir}/man1/wmnd.1* to catch all the possible compressions (and no compression) replace %defattr (-,root,root) with %defattr (-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review