https://bugzilla.redhat.com/show_bug.cgi?id=1761576 --- Comment #10 from Qianqian Fang <fangqq@xxxxxxxxx> --- thanks, I updated the spec file according to your above review https://github.com/fangq/fedorapkg/commit/079c4aa8182cd99993e4f1357446b905bede4c72 both the spec file and the srpm files are updated (url unchanged) > Also the builds you do in src/ do not seem to repect Fedora CFLAGS/CXXFLAGS, you need to fix that. I looked at my Makefile, and see that I did not use those standard flags. I will change this from upstream in the future releases, but will leave the spec file as you suggested in this initial package. let me know if this looks ok to you, thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx