https://bugzilla.redhat.com/show_bug.cgi?id=1761451 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review+ --- Comment #2 from Cole Robinson <crobinso@xxxxxxxxxx> --- The content is identical to https://bugzilla.redhat.com/show_bug.cgi?id=1590425#c12 , which I reviewed there. So duplicating that content here and approving the review: (In reply to Cole Robinson from comment #13) > The license/doc stuff is not doing what you think it's doing. There's only > a single LICENSE file that ends up in the RPM: > > $ rpm -qpl ./x86_64/kata-runtime-1.8.2-3.fc31.x86_64.rpm | grep LICENSE > /usr/share/licenses/kata-runtime/LICENSE > > Which LICENSE of the 3 mentioned? Not sure, maybe the first, but I > didn't confirm. > > And it does produce warnings: > $ rpmbuild --rebuild ./srpm/kata-runtime-1.8.2-3.fc32.src.rpm > ... > warning: File listed twice: /usr/share/doc/kata-runtime/README.md > warning: File listed twice: /usr/share/doc/kata-runtime/README.md > warning: File listed twice: /usr/share/doc/kata-runtime/README.md > warning: File listed twice: /usr/share/doc/kata-runtime/README.md > warning: File listed twice: /usr/share/doc/kata-runtime/README.md > warning: File listed twice: /usr/share/doc/kata-runtime/README.md > warning: File listed twice: /usr/share/doc/kata-runtime/README.md > warning: File listed twice: /usr/share/licenses/kata-runtime/LICENSE > warning: File listed twice: /usr/share/licenses/kata-runtime/LICENSE > ... > > For some reason the review is also spitting out an Issue that > wasn't there before, but I can't see what changed: > > Issues: > ======= > - Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/share/doc/kata-runtime/README.md > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_duplicate_files > > But it seems related. > > Otherwise this looks good to me. I'm approving the review but please > find a solution to those issues before performing a first build. Next > steps on your side are listed here: > https://fedoraproject.org/wiki/Package_Review_Process#Contributor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
