https://bugzilla.redhat.com/show_bug.cgi?id=1761459 --- Comment #2 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- Thanks for the review! > [!]: Uses parallel make %{?_smp_mflags} macro. > If this breaks the build it is not required, but it would be a good > idea to test this and/or add a comment to the %build section. Switched to "%make_build build"; it seems to work fine. > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ocaml- > ocplib-endian-devel > This could be missing? Ouch, yes, my bad. I wrote "isa" instead of "_isa"... fixed. Those were the two [!]s, let me know if anything else needs changing. Spec URL: https://tc01.fedorapeople.org/ocaml/lwt/ocaml-ocplib-endian.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/lwt/ocaml-ocplib-endian-1.0-2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
