https://bugzilla.redhat.com/show_bug.cgi?id=1761236 --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 473026560 bytes in /usr/share festival-2.5.0-8.fc32.x86_64.rpm:473016320 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines Make a noarch subpackage containing datadir elements - Add a Provides festival-static in the -devel subpackage: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: festival-devel. Does not provide -static: festival-devel. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries - Include COPYING.kal_diphone within %license: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING.kal_diphone is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text i.e. this should be %license not %doc: %files -n festvox-kal-diphone %doc COPYING.kal_diphone %dir %{_datadir}/festival/voices %dir %{_datadir}/festival/voices/english %{_datadir}/festival/voices/english/kal_diphone %files -n festvox-rab-diphone %doc COPYING.rab_diphone %dir %{_datadir}/festival/voices %dir %{_datadir}/festival/voices/english %{_datadir}/festival/voices/english/rab_diphone Those are BSD. - There's some BSD code too: BSD 3-clause "New" or "Revised" License --------------------------------------- festival/src/modules/hts_engine/COPYING festival/src/modules/hts_engine/HTS_audio.c festival/src/modules/hts_engine/HTS_engine.c festival/src/modules/hts_engine/HTS_engine.h festival/src/modules/hts_engine/HTS_gstream.c festival/src/modules/hts_engine/HTS_hidden.h festival/src/modules/hts_engine/HTS_label.c festival/src/modules/hts_engine/HTS_misc.c festival/src/modules/hts_engine/HTS_model.c festival/src/modules/hts_engine/HTS_pstream.c festival/src/modules/hts_engine/HTS_sstream.c festival/src/modules/hts_engine/HTS_vocoder.c festival/src/modules/hts_engine/Makefile festival/src/modules/hts_engine/README festival/src/modules/hts_engine/fest2hts_engine.cc Include it within the license field and add a comment explaining the license breakdown. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING.kal_diphone is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/festival See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: festival-devel. Does not provide -static: festival-devel. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "NTP License", "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* Public domain", "Expat License", "BSD 3-clause "New" or "Revised" License". 802 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/festival/review-festival/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in festival [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in festvox- kal-diphone , festvox-rab-diphone , festvox-awb-arctic-hts , festvox- bdl-arctic-hts , festvox-clb-arctic-hts , festvox-jmk-arctic-hts , festvox-rms-arctic-hts , festvox-slt-arctic-hts , festival-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 473026560 bytes in /usr/share festival-2.5.0-8.fc32.x86_64.rpm:473016320 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: festival-2.5.0-8.fc32.x86_64.rpm festvox-kal-diphone-0.19990610-8.fc32.noarch.rpm festvox-rab-diphone-0.19990610-8.fc32.noarch.rpm festvox-awb-arctic-hts-2.5.0-8.fc32.noarch.rpm festvox-bdl-arctic-hts-2.5.0-8.fc32.noarch.rpm festvox-clb-arctic-hts-2.5.0-8.fc32.noarch.rpm festvox-jmk-arctic-hts-2.5.0-8.fc32.noarch.rpm festvox-rms-arctic-hts-2.5.0-8.fc32.noarch.rpm festvox-slt-arctic-hts-2.5.0-8.fc32.noarch.rpm festival-devel-2.5.0-8.fc32.x86_64.rpm festival-debuginfo-2.5.0-8.fc32.x86_64.rpm festival-debugsource-2.5.0-8.fc32.x86_64.rpm festival-2.5.0-8.fc32.src.rpm festival.x86_64: E: explicit-lib-dependency speech-tools-libs festival.x86_64: W: no-manual-page-for-binary default_voices festival.x86_64: W: no-manual-page-for-binary festival_server festival.x86_64: W: no-manual-page-for-binary festival_server_control festival.x86_64: W: no-manual-page-for-binary saytime festival.x86_64: W: no-manual-page-for-binary text2wave festvox-kal-diphone.noarch: W: spelling-error %description -l en_US Prosodic -> Prosody festvox-rab-diphone.noarch: W: spelling-error %description -l en_US Prosodic -> Prosody festvox-awb-arctic-hts.noarch: W: spelling-error %description -l en_US labelled -> labeled, la belled, la-belled festvox-awb-arctic-hts.noarch: W: spelling-error %description -l en_US labelling -> labeling, la belling, la-belling festvox-awb-arctic-hts.noarch: W: no-documentation festvox-bdl-arctic-hts.noarch: W: spelling-error %description -l en_US labelled -> labeled, la belled, la-belled festvox-bdl-arctic-hts.noarch: W: spelling-error %description -l en_US labelling -> labeling, la belling, la-belling festvox-bdl-arctic-hts.noarch: W: no-documentation festvox-clb-arctic-hts.noarch: W: spelling-error %description -l en_US labelled -> labeled, la belled, la-belled festvox-clb-arctic-hts.noarch: W: spelling-error %description -l en_US labelling -> labeling, la belling, la-belling festvox-clb-arctic-hts.noarch: W: no-documentation festvox-jmk-arctic-hts.noarch: W: spelling-error %description -l en_US labelled -> labeled, la belled, la-belled festvox-jmk-arctic-hts.noarch: W: spelling-error %description -l en_US labelling -> labeling, la belling, la-belling festvox-jmk-arctic-hts.noarch: W: no-documentation festvox-rms-arctic-hts.noarch: W: spelling-error %description -l en_US labelled -> labeled, la belled, la-belled festvox-rms-arctic-hts.noarch: W: spelling-error %description -l en_US labeler -> libeler, labeled, label er festvox-rms-arctic-hts.noarch: W: no-documentation festvox-slt-arctic-hts.noarch: W: spelling-error %description -l en_US labelled -> labeled, la belled, la-belled festvox-slt-arctic-hts.noarch: W: spelling-error %description -l en_US labelling -> labeling, la belling, la-belling festvox-slt-arctic-hts.noarch: W: no-documentation festival.src: W: strange-permission festival-2.5.0-filesystem-standard.patch 600 festival.src: W: strange-permission festival-2.5.0-siteinit.patch 600 festival.src: W: strange-permission festival.service 600 festival.src:89: W: unversioned-explicit-provides festival-voice festival.src:90: W: unversioned-explicit-provides festvox-kallpc16k festival.src:97: W: unversioned-explicit-provides festival-voice festival.src:98: W: unversioned-explicit-provides festvox-rablpc16k festival.src:104: W: unversioned-explicit-provides festival-voice festival.src:110: W: unversioned-explicit-provides festival-voice festival.src:116: W: unversioned-explicit-provides festival-voice festival.src:122: W: unversioned-explicit-provides festival-voice festival.src:128: W: unversioned-explicit-provides festival-voice festival.src:134: W: unversioned-explicit-provides festival-voice festival.src:307: W: macro-in-comment %{_libdir} festival.src:474: W: macro-in-%changelog %{_sysconfdir} festival.src:475: W: macro-in-%changelog %{_infodir} festival.src:476: W: macro-in-%changelog %files festival.src:491: W: macro-in-%changelog %{_datadir} festival.src:507: W: macro-in-%changelog %{_libdir} 13 packages and 0 specfiles checked; 1 errors, 44 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
