https://bugzilla.redhat.com/show_bug.cgi?id=1761236 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Only one of this is necessary: Requires: festival-lib = %{version}-%{release} Requires: festival-lib - Use %make_build instead of make - Just simplify this into %{_datadir}/festival, we don't need to be so specific %dir %{_datadir}/festival %{_datadir}/festival/*.scm %{_datadir}/festival/festival.el %{_datadir}/festival/*.ent %{_datadir}/festival/*.gram %{_datadir}/festival/*.dtd %{_datadir}/festival/*.ngrambin %{_datadir}/festival/speech.properties %{_datadir}/festival/dicts %dir %{_datadir}/festival/multisyn %{_datadir}/festival/multisyn/*.scm %dir %{_datadir}/festival/examples %{_datadir}/festival/examples/intro.text Same for %{_libexecdir}/festival - use install -p to keep timestamps - I don't get the need for the lib package? %files lib %license COPYING There's nothing in it? - Why is this provided? There's no conf file to go along? # the actual /etc. :) mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/festival - Same. Why create this if you don't provide info files? # info pages mkdir -p $RPM_BUILD_ROOT%{_infodir} These is a Makefile in doc/ to create Info and man pages - Maybe snag some interesting patches from Debian? https://packages.debian.org/sid/festival - Build does not respect Fedora build flags. You're missing a \ after thi libdir line: make \ EST=%{_libdir}/speech_tools \ LIBDIR="%{_libdir}" \ CFLAGS="$RPM_OPT_FLAGS -fPIC" \ CXXFLAGS="$RPM_OPT_FLAGS -fPIC" Probably could remove after that: # This seems to avoid malfunction # "error: Empty %files file /home/mike/Source/rpms/BUILD/festival/debugsourcefiles.list" %global debug_package %{nil} - Package can't be installed: DEBUG util.py:595: Problem: conflicting requests DEBUG util.py:595: - nothing provides festival-lib = 0.19990610-7.fc32 needed by festival-devel-2.5.0-7.fc32.x86_64 Version is redefined by Version: %{diphoneversion} so this fails. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
