[Bug 1760115] Review Request: maven-osgi - Library for Maven-OSGi integration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1760115



--- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #1)
>  - License must be included with %license, not %doc 
> 
> %license LICENSE

Good catch. Fixed.

>  - Obsoletes should be fixed, not dynamic. It should be the version-release
> just above the package you are obsoleting.
> 
> Obsoletes:      maven-shared-osgi < %{epoch}:%{version}-%{release}
> Provides:       maven-shared-osgi = %{epoch}:%{version}-%{release}
> 
> Besides this dates back to Fedora 18 so it can be safely removed now. This
> should have been removed by Fedora 22 times.

You're right. I've removed these two lines. fedora 22 can stay dead :)

>  - You should also remove %dir %{_javadir}/%{name} from %files, it seems
> already provided by -f .mfiles

Curious, I ran rpmbuild on my locally built RPMs, and I didn't see this error,
I think.
But it's fixed now.

Updated .spec and SRPM available from the same links.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux