https://bugzilla.redhat.com/show_bug.cgi?id=1760617 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |sanjay.ankur@xxxxxxxxx Flags| |fedora-review? --- Comment #8 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- The new bugzilla hides the blocks/depends field under "Advanced fields". If you click the button, it should show the fields. Here is the review, but I'll have to do it again once you regenerate the SRPM from the new spec and upload that: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Should the main spec/package be simply called mmc and then octave-.. as sub-packages instead of the other way round? - Why does the build require vim-common? - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text COPYING is required for the octave package, so this looks OK. - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5703680 bytes in 190 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation Please move the docs to the a sub-package. - Lots of bundling here too. Is this required? $ licensecheck -r . | sed '/UNKNOWN/ d' ./LICENSE.txt: GPL (v3 or later) ./mmclab/LICENSE.txt: GPL (v3 or later) ./src/drand48_r_libgw32c.c: GNU Lesser General Public License (v2.1 or later) ./src/mmcdoxy.cfg: *No copyright* GENERATED FILE ./src/nifti1.h: Public domain ./examples/onecube/README.txt: *No copyright* GENERATED FILE ./examples/reftest/README.txt: *No copyright* GENERATED FILE ./mmclab/example/demo_head_atlas.m: *No copyright* GENERATED FILE ./src/SFMT/LICENSE.txt: BSD 3-clause "New" or "Revised" License ./src/cjson/LICENSE: Expat License ./src/cjson/README: Expat License ./src/cjson/cJSON.c: Expat License ./src/cjson/cJSON.h: Expat License ./src/cjson/test.c: Expat License ./src/sse_math/sse_math.h: zlib/libpng license ./src/waitmex/license.txt: BSD 3-clause "New" or "Revised" License - Build flags aren't used. Example from the build.log file: Building built/mmc.o cc -c -Wall -g -DMCX_EMBED_CL -fno-strict-aliasing -m64 -DMMC_USE_SSE -DHAVE_SSE2 -msse -msse2 -msse3 -mssse3 -msse4.1 -O3 -fopenmp -fPIC -DMCX_CONTAINER -DUSE_OS_TIMER -DUSE_OPENCL -I../src -o built/mmc.o mmc.c Please use %{set_opt_flags} before you run %make_build - You do not need to use pushd, you can use %make_build -C <directory name> - There's still the ln -s mex etc. Is this the latest srpm? (Each time you update the spec file, you need to regenerate the srpm and upload the latest versions of both.) - Quite a few rpmlint issues. Please correct them. Some hints here: https://fedoraproject.org/wiki/Common_Rpmlint_issues ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. ^ Is this also bundling lots of things? Is this required? $ licensecheck -r . | sed '/UNKNOWN/ d' ./LICENSE.txt: GPL (v3 or later) ./mmclab/LICENSE.txt: GPL (v3 or later) ./src/drand48_r_libgw32c.c: GNU Lesser General Public License (v2.1 or later) ./src/mmcdoxy.cfg: *No copyright* GENERATED FILE ./src/nifti1.h: Public domain ./examples/onecube/README.txt: *No copyright* GENERATED FILE ./examples/reftest/README.txt: *No copyright* GENERATED FILE ./mmclab/example/demo_head_atlas.m: *No copyright* GENERATED FILE ./src/SFMT/LICENSE.txt: BSD 3-clause "New" or "Revised" License ./src/cjson/LICENSE: Expat License ./src/cjson/README: Expat License ./src/cjson/cJSON.c: Expat License ./src/cjson/cJSON.h: Expat License ./src/cjson/test.c: Expat License ./src/sse_math/sse_math.h: zlib/libpng license ./src/waitmex/license.txt: BSD 3-clause "New" or "Revised" License [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [!]: %build honors applicable compiler flags or justifies otherwise. They do not. Example from the build.log file: Building built/mmc.o cc -c -Wall -g -DMCX_EMBED_CL -fno-strict-aliasing -m64 -DMMC_USE_SSE -DHAVE_SSE2 -msse -msse2 -msse3 -mssse3 -msse4.1 -O3 -fopenmp -fPIC -DMCX_CONTAINER -DUSE_OS_TIMER -DUSE_OPENCL -I../src -o built/mmc.o mmc.c Please use %{set_opt_flags} before you run %make_build [!]: Package contains no bundled libraries without FPC exception. cjson, SFMT, sse_math, waitmex and others are bundled. Either they need to be unbundled, or specified, and license updated accordingly. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines ^ Issues noted. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mmclab- demos , mmc , mmc-demos Do the Requires be versioned? https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires [?]: Package functions as described. ^ Not yet tested [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) ^ This confirms that the generated srpm does not match the latest spec. Please post the newest ones. [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: octave-mmclab-1.7.9-1.fc32.x86_64.rpm mmclab-demos-1.7.9-1.fc32.noarch.rpm mmc-1.7.9-1.fc32.x86_64.rpm mmc-demos-1.7.9-1.fc32.noarch.rpm octave-mmclab-debuginfo-1.7.9-1.fc32.x86_64.rpm octave-mmclab-debugsource-1.7.9-1.fc32.x86_64.rpm octave-mmclab-1.7.9-1.fc32.src.rpm octave-mmclab.x86_64: W: dangerous-command-in-%preun mv mmclab-demos.noarch: W: spelling-error Summary(en_US) datasets -> data sets, data-sets, databases mmclab-demos.noarch: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases mmclab-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmclab-demos/example/demo_sfdi_2layer.m mmc.x86_64: W: spelling-error Summary(en_US) datasets -> data sets, data-sets, databases mmc.x86_64: W: no-manual-page-for-binary mmc mmc-demos.noarch: W: spelling-error Summary(en_US) datasets -> data sets, data-sets, databases mmc-demos.noarch: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/colin27/prop_brain.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/dcs/dcs.inp ^ Please remove the executable perm mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/dcs/dcs_g1_Db.m mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/dcs/dcs_g1_Db_fms.m mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/dcs/dcs_g2_Db.m mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/dcs/dcs_g2_Db_fms.m ^ Please correct this mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/dcs/prop_dcs.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/meshtest/prop_mesh0.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/meshtest/prop_mesh1.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/meshtest/prop_mesh2.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/onecube/prop_onecube.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/reftest/prop_onecube.dat ^ Please correct this mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/regression/exitangle/phantom.m ^ Please correct this mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/replay/prop_replaytest.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/replaywide/prop_replaywide.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/rngtest/Makefile ^ Please correct this mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sfdi2layer/README.txt mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sfdi2layer/createmesh.m mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sfdi2layer/prop_sfdi.dat mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sfdi2layer/sfdi.inp mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sharing/README.txt mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sharing/prop_sharing.dat mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sharing/sharing.inp ^ Please correct this mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/validation/prop_cube.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/validation/prop_cube2.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/widedet/prop_widedet.dat ^ Please correct this 7 packages and 0 specfiles checked; 0 errors, 34 warnings. Rpmlint (debuginfo) ------------------- Checking: octave-mmclab-debuginfo-1.7.9-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). mmc-demos.noarch: W: spelling-error Summary(en_US) datasets -> data sets, data-sets, databases mmc-demos.noarch: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases mmc-demos.noarch: W: invalid-url URL: http://mcx.space/#mmc <urlopen error [Errno -2] Name or service not known> mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/colin27/prop_brain.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/dcs/dcs.inp mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/dcs/dcs_g1_Db.m mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/dcs/dcs_g1_Db_fms.m mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/dcs/dcs_g2_Db.m mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/dcs/dcs_g2_Db_fms.m mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/dcs/prop_dcs.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/meshtest/prop_mesh0.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/meshtest/prop_mesh1.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/meshtest/prop_mesh2.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/onecube/prop_onecube.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/reftest/prop_onecube.dat mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/regression/exitangle/phantom.m mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/replay/prop_replaytest.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/replaywide/prop_replaywide.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/rngtest/Makefile mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sfdi2layer/README.txt mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sfdi2layer/createmesh.m mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sfdi2layer/prop_sfdi.dat mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sfdi2layer/sfdi.inp mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sharing/README.txt mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sharing/prop_sharing.dat mmc-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmc-demos/examples/sharing/sharing.inp mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/validation/prop_cube.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/validation/prop_cube2.dat mmc-demos.noarch: W: spurious-executable-perm /usr/share/doc/mmc-demos/examples/widedet/prop_widedet.dat octave-mmclab-debugsource.x86_64: W: invalid-url URL: http://mcx.space/#mmc <urlopen error [Errno -2] Name or service not known> octave-mmclab.x86_64: W: invalid-url URL: http://mcx.space/#mmc <urlopen error [Errno -2] Name or service not known> octave-mmclab.x86_64: W: dangerous-command-in-%preun mv mmc.x86_64: W: spelling-error Summary(en_US) datasets -> data sets, data-sets, databases mmc.x86_64: W: invalid-url URL: http://mcx.space/#mmc <urlopen error [Errno -2] Name or service not known> mmc.x86_64: W: no-manual-page-for-binary mmc octave-mmclab-debuginfo.x86_64: W: invalid-url URL: http://mcx.space/#mmc <urlopen error [Errno -2] Name or service not known> mmclab-demos.noarch: W: spelling-error Summary(en_US) datasets -> data sets, data-sets, databases mmclab-demos.noarch: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases mmclab-demos.noarch: W: invalid-url URL: http://mcx.space/#mmc <urlopen error [Errno -2] Name or service not known> mmclab-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mmclab-demos/example/demo_sfdi_2layer.m 6 packages and 0 specfiles checked; 0 errors, 40 warnings. Source checksums ---------------- https://github.com/fangq/mmc/archive/v1.7.9/mmc-1.7.9.tar.gz : CHECKSUM(SHA256) this package : b5533a639a0efe7de2785358c6b2ef1ba2228f00fffd35faf9fd0b42f8040e64 CHECKSUM(SHA256) upstream package : b5533a639a0efe7de2785358c6b2ef1ba2228f00fffd35faf9fd0b42f8040e64 Requires -------- octave-mmclab (rpmlib, GLIBC filtered): /bin/sh libOpenCL.so.1()(64bit) libOpenCL.so.1(OPENCL_1.0)(64bit) libOpenCL.so.1(OPENCL_1.2)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) octave octave-iso2mesh opencl-filesystem rtld(GNU_HASH) mmclab-demos (rpmlib, GLIBC filtered): octave octave-iso2mesh octave-mmclab mmc (rpmlib, GLIBC filtered): libOpenCL.so.1()(64bit) libOpenCL.so.1(OPENCL_1.0)(64bit) libOpenCL.so.1(OPENCL_1.2)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) octave octave-iso2mesh opencl-filesystem rtld(GNU_HASH) mmc-demos (rpmlib, GLIBC filtered): octave octave-iso2mesh octave-mmclab-debuginfo (rpmlib, GLIBC filtered): octave-mmclab-debugsource (rpmlib, GLIBC filtered): Provides -------- octave-mmclab: octave-mmclab octave-mmclab(x86-64) mmclab-demos: mmclab-demos mmc: mmc mmc(x86-64) mmc-demos: mmc-demos octave-mmclab-debuginfo: debuginfo(build-id) octave-mmclab-debuginfo octave-mmclab-debuginfo(x86-64) octave-mmclab-debugsource: octave-mmclab-debugsource octave-mmclab-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/asinha/dump/fedora-review/1760617-octave-mmclab/srpm/octave-mmclab.spec 2019-10-13 18:11:35.017723858 +0100 +++ /home/asinha/dump/fedora-review/1760617-octave-mmclab/srpm-unpacked/octave-mmclab.spec 2019-10-11 00:04:24.000000000 +0100 @@ -6,9 +6,9 @@ Version: 1.7.9 Release: 1%{?dist} -Summary: A GPU mesh-based Monte Carlo photon simulator for MATLAB/Octave +Summary: A GPU Mesh-based Monte Carlo photon simulator for MATLAB/Octave License: GPLv3+ URL: http://mcx.space/#mmc Source0: https://github.com/fangq/%{project}/archive/v%{version}/%{project}-%{version}.tar.gz -BuildRequires: octave-devel gcc-c++ vim-common opencl-headers ocl-icd-devel +BuildRequires: octave-devel gcc-c++ vim-common opencl-headers ocl-icd-devel Requires: octave opencl-filesystem octave-iso2mesh @@ -28,5 +28,5 @@ %package -n %{octpkg}-demos -Summary: Example datasets and scripts for MMCLAB toolbox +Summary: Example datasets and scripts for the MMCLAB toolbox BuildArch: noarch Requires: octave octave-%{octpkg} octave-iso2mesh @@ -36,5 +36,5 @@ %package -n %{project} -Summary: Example datasets and scripts for mesh-based Monte Carlo (MMC) +Summary: Example datasets and scripts for the MMCLAB toolbox BuildRequires: octave-devel gcc-c++ vim-common opencl-headers ocl-icd-devel Requires: octave opencl-filesystem octave-iso2mesh @@ -146,6 +146,8 @@ rm %{octpkg}/*.txt mv %{octpkg}/example . +mv %{octpkg}/*.mex . mv %{octpkg} inst mv src/Makefile . +ln -s %{_libexecdir}/%{octpkg}/%{branch}.mex inst/%{branch}.mex %octave_pkg_build @@ -165,6 +167,9 @@ %octave_pkg_install +install -m 0755 -vd %{buildroot}%{_libexecdir}/%{octpkg} +install -m 0755 -vp %{branch}.mex %{buildroot}%{_libexecdir}/%{octpkg}/ + install -m 0755 -vd %{buildroot}%{_bindir} -install -m 0755 -vt %{buildroot}%{_bindir} bin/%{project} +install -m 0755 -t %{buildroot}%{_bindir} bin/%{project} %post @@ -180,4 +185,6 @@ %license LICENSE.txt %doc README.txt AUTHORS.txt +%dir %{_libexecdir}/%{octpkg} +%{_libexecdir}/%{octpkg}/*.mex %dir %{octpkgdir} %{octpkgdir}/*.m Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1760617 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: C/C++, Shell-api, Generic Disabled plugins: Java, Python, Perl, fonts, PHP, R, SugarActivity, Ocaml, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
