https://bugzilla.redhat.com/show_bug.cgi?id=1758626 --- Comment #42 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Qianqian Fang from comment #34) > @Ankur, @Robert-Andre and @Laurent, thank you all for the comments and help > on creating this package. > > the latest spec file can be found on the src git site: > https://src.fedoraproject.org/rpms/octave-iso2mesh/blob/master/f/octave- > iso2mesh.spec > > In the -3 version of this initial package, all the above mentioned issues > were addressed, including > > - thanks for Rob's patch, the binaries are now moved to /usr/libexec, and > some of the license issues found by @Laurent > > - per early discussions on setting octave-pkg-level dependency to get better > modulation, I was able to get help from Mike Miller from the octave mailing > list, and made the following patch > https://src.fedoraproject.org/rpms/octave-iso2mesh/c/ > 2a98febb8e720aa03fc2f87f8744a379f4fe69db?branch=master > basically, rpm takes care of the rpm-package level dependency, and Depends > in DESCRIPTION file also load dependencies in octave; because this is > possible now, I have removed the duplicate functions from jsonlab and jnifti > from iso2mesh > > - the gmp-devel dependency was removed, but I don't understand why rpmlint > calls this an error (the binaries clearly needs this library) - per Ankur's > comment earlier, it does no harm to explicitly define such dependency > despite overlapping, but seems rpmlint treats this as an conflict. > > - the licenses of sub-tools are clarified in the comments > > > the below are no longer an issue any more, but I want to keep a note here > > - I changed %make_build to make because it failed building the package on > f31/f32; I later on reverted it to "%make_build" again, and that change once > again failed the builds - the last line before failing is linking the cgal > binaries. So, it is clear there is some issue using %make_build (i.e. SMP > parallel building) with cgal targets, @Laurent, is this a known issue for > CGAL? The log for one of the failed task can be found here > > https://src.fedoraproject.org/rpms/octave-iso2mesh/c/ > 2a98febb8e720aa03fc2f87f8744a379f4fe69db?branch=master That is fine. If the tool does not support parallel make, you can use simple make (with -j1). > > - now I put arm as ExcludeArch, because @Ankur had a failed build on arm, > and the error was "virtual memory exhausted" for CGAL, see > https://koji.fedoraproject.org/koji/taskinfo?taskID=38115425 , if we have a > way to build on arm, I will drop the ExcludeArch, but this is not a priority The guidelines require you to file a bug. Please do that if you haven't done so yet: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support > > I am going to close this ticket for now, thanks again. feel free to reopen > if any issue appears. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
