https://bugzilla.redhat.com/show_bug.cgi?id=1758293 --- Comment #10 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I've applied some changes on top of your new .spec file, with the following suggestions for improvements: - added License file for Apache 2.0 license (apparently it must be included in redistributed sources), but it's missing from upstream :( - reordered BuildRequires - remove one test that requires "roaster" stuff and enable test suite (instead of disabling it entirely). tests pass! :) - add README and LICENSE to %files Diff of my suggestions: https://src.fedoraproject.org/fork/decathorpe/rpms/jboss-logging-tools/c/b5dd0f1?branch=master -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
