https://bugzilla.redhat.com/show_bug.cgi?id=1758626 --- Comment #25 from Laurent Rineau <laurent.rineau__fedora@xxxxxxxxxxxxxx> --- (In reply to Laurent Rineau from comment #21) > I love to see iso2mesh packaged in Fedora, but there have been error in this > review. Even rpmlint can see them: > > [lrineau@bonnard]~% rpm -q octave-iso2mesh; rpmlint octave-iso2mesh > octave-iso2mesh-1.9.1-1.fc30.x86_64 > octave-iso2mesh.x86_64: E: devel-dependency gmp-devel You should remove the dependency to 'gmp-devel'. The dependency to 'gmp' will be found automatically once the binaries are correctly installed according to Fedora's rules. > octave-iso2mesh.x86_64: E: arch-dependent-file-in-usr-share > /usr/share/octave/packages/iso2mesh-1.9.1/bin/cgalmesh > octave-iso2mesh.x86_64: E: arch-dependent-file-in-usr-share > /usr/share/octave/packages/iso2mesh-1.9.1/bin/cgalpoly > octave-iso2mesh.x86_64: E: arch-dependent-file-in-usr-share > /usr/share/octave/packages/iso2mesh-1.9.1/bin/cgalsimp2 > octave-iso2mesh.x86_64: E: arch-dependent-file-in-usr-share > /usr/share/octave/packages/iso2mesh-1.9.1/bin/cgalsurf > octave-iso2mesh.x86_64: E: arch-dependent-file-in-usr-share > /usr/share/octave/packages/iso2mesh-1.9.1/bin/cork > octave-iso2mesh.x86_64: E: arch-dependent-file-in-usr-share > /usr/share/octave/packages/iso2mesh-1.9.1/bin/jmeshlib > octave-iso2mesh.x86_64: E: arch-dependent-file-in-usr-share > /usr/share/octave/packages/iso2mesh-1.9.1/bin/meshfix > octave-iso2mesh.x86_64: E: arch-dependent-file-in-usr-share > /usr/share/octave/packages/iso2mesh-1.9.1/bin/tetgen1.5 All those "tools" should be in /usr/libexec/iso2mesh/ instead of /usr/share/octave/packages/iso2mesh-1.9.1/bin/. The mex files should be able to run the tools. If you want to be lazy, just move the tools into /usr/libexec/iso2mesh/ and package symbolic links in /usr/share/octave/packages/iso2mesh-1.9.1/bin/. (In reply to Qianqian Fang from comment #22) > 2. regarding tetgen, please see Comment 4 and Comment 5 for the discussions. > These are internal tools and are not intend to be called outside of > iso2mesh. I prefer to bundle these tools as much as possible to allow a mesh > reproduced across platforms, and does not reply on the versions of a tool > installed on a user's system (wish I could do the same for cgal, but it is > too big to be bundled internally). Many of my other tools (such as mmc: > http://mcx.space/#mmc) rely on a reproducible mesh to run examples > correctly. Also, bundling this utility is allowed by their respective > licenses. All right. The guidelines at https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling says 'SHOULD' and not 'MUST'. As for CGAL, as CGAL is a header-only library of C++ templates, you just have to be careful when the package is rebuilt. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
