https://bugzilla.redhat.com/show_bug.cgi?id=1709037 --- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Raphael Groner from comment #10) > Thanks for your advice. Though, I don't see any blockers to approve, > otherwise please guide me in our official packaging guidelines. > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > Missing: BR: gcc https://docs.fedoraproject.org/en-US/packaging-guidelines/#buildrequires > > Also, having a description for the binary package which does not get created is strange. > It's suggested in the official python sample. No idea if rpmbuild accepts an > empty main description. Hmm, I think I was totally wrong here, please ignore. > > → maybe add BR: python%{python3_pkgversion}-coverage to avoid the warning? > No, coverage is not relevant for the package build, that seems to be a > feature for upstream only. Ack. > > It seems unversioned python is being called. > I fail to see for what step of the build task this counts. Calling unversioned python is against the guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python_version_support): "Packages in Fedora MUST NOT use /usr/bin/python". Among other things, it will also be allowed to have no /usr/bin/python at all in local installations. /usr/bin/python3 should be called. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
