https://bugzilla.redhat.com/show_bug.cgi?id=1752196 --- Comment #10 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Hi, this package uses the new pyproject macros [https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/LB3GTGGWEKBT2QWOB77XQ3WXEWN4XRUK/]. > - Package contains BR: python2-devel or python3-devel That is not needed, "BuildRequires: pyproject-rpm-macros" pulls in the necessary deps. > [?]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > => Please explain why you use BSD. https://pypi.org/project/pytest-harvest/ shows License: BSD License (BSD 3-Clause), as does https://github.com/smarie/python-pytest-harvest/blob/master/LICENSE. > [!]: License field in the package spec file matches the actual license. > Note: There is no build directory. Running licensecheck on vanilla > upstream sources. No licenses found. Please check the source files for > licenses manually. > => Empty licensecheck.txt generated, why? Some problem with fedora-review maybe? Nothing I can fix. > [!]: A package which is used by another package via an egg interface should > provide egg info. The binary package provides this: /usr/lib/python3.7/site-packages/pytest_harvest-1.7.2.dist-info/ > [!]: Package meets the Packaging Guidelines::Python It does, afaict. It's using the new macros to automate this, but the end result should be correct according to the guidelines. > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. The source tarball includes "LICENSE", and this file is also present in the binary rpm. (In reply to Raphael Groner from comment #9) > > [?]: Binary eggs must be removed in %prep > > Note: Cannot find any build in BUILD directory (--prebuilt option?) > > Maybe better try to build from source instead of using pypi provides > binaries only. It is built from source. It is a pure-python package, so "source" and "binary" are pretty much the same, but fwiw, it is built from a "source" tarball downloaded from pypi (as most python packages are...). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
