[Bug 1747552] Review Request: libdfp - Decimal Floating Point library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1747552



--- Comment #6 from Tulio Magno Quites Machado Filho <tulioqm@xxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #5)
> You haven't addressed the follozwing: 
> 
>  - Missing isa in %package devel 
> 
> Requires:	%{name}%{?_isa} = %{version}-%{release}

I can't find this line:
$ git grep -En '^Requires:'
libdfp.spec:41:Requires:        %{name} = %{version}-%{release}

What am I missing?

>  - It seems it should be:
> 
> %prep
> %autosetup -p1 -n %{name}-%{version}
> 
> 
>  - Not needed: %defattr(-,root,root,-) in %files devel

Oops.  Sorry.  I fixed both issues now.
I decided to drop -n completely because the current package from upstream
conforms to the %{name}-%{version} as expected by RPM.  Is that OK?

Spec URL: https://pagure.io/libdfp/raw/master/f/libdfp.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/tuliom/libdfp/fedora-31-ppc64le/01051662-libdfp/libdfp-1.0.14-6.fc31.src.rpm

Results of the tests are available at:
https://copr.fedorainfracloud.org/coprs/tuliom/libdfp/build/1051662/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux