https://bugzilla.redhat.com/show_bug.cgi?id=1759928 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- I'd put Summary below Name and Version... Looks strange to have it as the first thing. "providing several useful features relative to resample-1.7" — I don't think most users can make any use of this comparison. make VERBOSE=1 %{?_smp_mflags} → %make_build VERBOSE=1 %{_libdir}/libresample.so.* → a specific pattern would be better. The guidelines changed on this recently [https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files] But since the project is dead upstream, this doesn't really matter. rpmlint: libresample.x86_64: W: no-soname /usr/lib64/libresample.so.0 libresample.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libresample.so.0 /lib64/libsamplerate.so.0 libresample.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libresample.so.0 /lib64/libsndfile.so.1 ... (other warnings omitted) 5 packages and 0 specfiles checked; 2 errors, 14 warnings. + name is OK + license is (still) OK + builds and installs OK + latest version ;) Package is RE-APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
