https://bugzilla.redhat.com/show_bug.cgi?id=1758036 --- Comment #6 from Kentaro Hayashi <kenhys@xxxxxxxxx> --- Thank you for reviewing. I've updated spec. Spec URL: https://packages.groonga.org/tmp/sentencepiece/sentencepiece.spec SRPM URL: https://packages.groonga.org/tmp/sentencepiece/sentencepiece-0.1.83-1.fc30.src.rpm Description: unsupervised text tokenizer for Neural Network-based text generation (In reply to Robert-André Mauchin from comment #5) > - You must include the python provide macros *for your Python package*: > > %package -n python3-%{name} > Summary: Python module for SentencePiece > %{?python_provide:%python_provide python3-%{name}} > > See > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_the_python_provide_macro > I've fixed to define macro correctly. > You should not include it in the main package. > > - Also use Fedora build flags:: cmake3 . -DCMAKE_INSTALL_PREFIX=%{_prefix} > -DCMAKE_INSTALL_LIBDIR=%{_libdir} → %cmake3 . > -DCMAKE_INSTALL_LIBDIR=%{_libdir} I've fixed to use %cmake macro instead. * Fixed to -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
