[Bug 1758499] Review Request: procdump - Process coredumps based on performance triggers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1758499



--- Comment #10 from Neal Gompa <ngompa13@xxxxxxxxx> ---
(In reply to Matej Grabovsky from comment #8)
> (In reply to Neal Gompa from comment #7)
> > The upstream spec file indicates that this won't work:
> > https://github.com/microsoft/ProcDump-for-Linux/blob/master/dist/procdump.
> > spec.in#L40-L41
> 
> Since you're the author, can you please explain why? "This won't work" is
> quite a strong statement which I have successfully disproved above. I have
> never encountered any problems with parallel builds and from a quick glance
> at the makefile, I can't infer why that would be a problem. I'd be happy to
> correct my conclusions if you find them incorrect.

The ordering of the files and compilation units for building wound up being
randomly broken for me when I was doing this a while ago. It was easier to not
do it than it was to do it.

That said, if it always works now, just make sure you change it to the
following:

> %make_build CFLAGS="%{optflags}"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux