https://bugzilla.redhat.com/show_bug.cgi?id=1759354 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - I would put this within the main package: %{_datadir}/applications/%{name}.desktop And you need to validate it: BuildRequires: desktop-file-utils […] desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop - Providing an Appdata file would be nice too. - Include doc/manual/ with %doc? - %{gittag} is not defined in your spec so this fails: Source0: https://github.com/%{github_owner}/%{name}/archive/%{gittag}/%{name}-%{pkgversion}.%{archive_suffix} - commit 0a422b5 doesn't seem to exist - SPEC and SPEC in SRPM differ, one has a patch, the other has not. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
