[Bug 1758929] Review Request: perl-WebService-MusicBrainz - Perl interface to search the musicbrainz.org database

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1758929

Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
Rpmlint
-------
Checking: perl-WebService-MusicBrainz-1.0.5-2.fc32.noarch.rpm
          perl-WebService-MusicBrainz-1.0.5-2.fc32.src.rpm
perl-WebService-MusicBrainz.noarch: W: invalid-license Artistic
perl-WebService-MusicBrainz.src: W: invalid-license Artistic
perl-WebService-MusicBrainz.src:10: W: mixed-use-of-spaces-and-tabs (spaces:
line 3, tab: line 10)
perl-WebService-MusicBrainz.src: E: specfile-error warning: bogus date in
%changelog: Mon Oct 06 2019 Gerald Cox <gbcox@
fedoraproject.org> - 1.0.5-2
2 packages and 0 specfiles checked; 1 errors, 3 warnings.

-> Please fix mixed spaces and tabs and bogus date in changelog.

Rpmlint (installed packages)
----------------------------
perl-WebService-MusicBrainz.noarch: W: description-shorter-than-summary
perl-WebService-MusicBrainz.noarch: W: invalid-license Artistic
perl-WebService-MusicBrainz.noarch: W: invalid-url URL:
https://metacpan.org/release/WebService-MusicBrainz <urlopen err
or [Errno -2] Name or service not known>
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

-> Could you change the %description to:
This module will search the MusicBrainz database through their web service and
return objects with the found data.

I would also make the files list a bit more specific:
%files
%doc Changes README.md
%{_mandir}/man3/WebService::MusicBrainz*.3pm*
%{perl_vendorlib}/WebService

The above can be fixed while importing. The rest is fine, so package is
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux