https://bugzilla.redhat.com/show_bug.cgi?id=1759276 --- Comment #6 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Luke Hinds from comment #5) > Regarding #c3 - those are not libraries, they are CLI `entry_points` and > need to be execution able and have a shebang. > Should not be necessary. > I will look into #c1 tomorrow (thanks for outline everything), in regards to > #c2 I guess that must be coming from setup.py which I am surprised is being > sourced, as we use the `python3-tornado` package in Depends. I will move it > up to 6.0.2 upstream. As said previously, we are now using an automatic dependency generator which reads setup.py Proposed patch for static files: diff -up keylime-5.2.0/setup.py.orig keylime-5.2.0/setup.py --- keylime-5.2.0/setup.py.orig 2019-10-07 18:27:32.000000000 +0200 +++ keylime-5.2.0/setup.py 2019-10-07 23:22:20.893659697 +0200 @@ -49,8 +49,7 @@ if '--with-clime' in sys.argv: sys.argv.remove('--with-clime') # enumerate all of the data files we need to package up -data_files = [(d, [path.join(d,f) for f in files]) for d,_,files in walk("keylime/static")] -data_files.append(('package_default', ['keylime.conf'])) +data_files = [('/etc', ['keylime.conf'])] setup( name='keylime', @@ -104,6 +103,7 @@ setup( # You can just specify the packages manually here if your project is # simple. Or you can use find_packages(). packages=['keylime'], + package_data={'keylime': ['static/*/*', 'static/*/*/*']}, # List run-time dependencies here. These will be installed by pip when # your project is installed. For an analysis of "install_requires" vs pip's I haven't tested it to see if static files aro found by the script. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
