https://bugzilla.redhat.com/show_bug.cgi?id=1759276 --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Not used in Fedora: Group: Development/Libraries Vendor: Keylime Developers AutoReq: no - Not right and not needed: %defattr(755,root,root) - This is useless: %define name keylime %define version 5.2.0 %define release 1 Use the normal RPM fields, don't redefine them, also don't forget the %{?dist} tag in Release: Name: keylime Version: 5.2.0 Release: 1%{?dist} - Don't reinclude all the *.py: %{python3_sitelib}/%{srcname}/ca_util.py %{python3_sitelib}/%{srcname}/cloud_agent.py %{python3_sitelib}/%{srcname}/cloud_verifier_common.py %{python3_sitelib}/%{srcname}/cloud_verifier_tornado.py %{python3_sitelib}/%{srcname}/ima_emulator_adapter.py %{python3_sitelib}/%{srcname}/provider_platform_init.py %{python3_sitelib}/%{srcname}/provider_registrar.py %{python3_sitelib}/%{srcname}/provider_vtpm_add.py %{python3_sitelib}/%{srcname}/registrar.py %{python3_sitelib}/%{srcname}/tenant.py %{python3_sitelib}/%{srcname}/tenant_webapp.py %{python3_sitelib}/%{srcname}/user_data_encrypt.py You already included them by stating: %{python3_sitelib}/%{srcname} - Don't include this twice as well: %{_sysconfdir}/%{srcname}.conf %config(noreplace) %{_sysconfdir}/%{srcname}.conf → Only this is necessary: %config(noreplace) %{_sysconfdir}/%{srcname}.conf - Use a better name for your archive: Source0: https://github.com/keylime/keylime/archive/%{version}/%{name}-%{version}.tar.gz - This does not respect the FHS: %{_prefix}/%{srcname}/static/* See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_exceptions_2 This should probably go to %{_datadir}/%{srcname} (/usr/share/keylime) Ask upstream to fix their install process. - Not needed as %?python_enable_dependency_generator is enabled by default. Add this macro manually for EPEL. Requires: python3-pyyaml Requires: python3-m2crypto Requires: python3-cryptography Requires: python3-tornado Requires: python3-simplejson Requires: python3-requests Requires: python3-zmq See https://fedoraproject.org/wiki/Changes/EnablingPythonGenerators - You need to include the SystemD scriptlets: see https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#Systemd BuildRequires: systemd-rpm-macros […] %post %systemd_post %{srcname}_agent.service %systemd_post %{srcname}_verifier.service %systemd_post %{srcname}_registrar.service %preun %systemd_preun %{srcname}_agent.service %systemd_preun %{srcname}_verifier.service %systemd_preun %{srcname}_registrar.service %postun %systemd_postun_with_restart %{srcname}_agent.service %systemd_postun_with_restart %{srcname}_verifier.service %systemd_postun_with_restart %{srcname}_registrar.service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
