[Bug 1758622] Review Request: octave-mcxlab - A GPU Monte Carlo 3-D photon transport simulator for MATLAB/Octave

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1758622



--- Comment #8 from Qianqian Fang <fangqq@xxxxxxxxx> ---
@eclipseo, the bug you found was exactly the one that caused the earlier
problem, and I confirm the patch works. 

I also added a condition to wrap around this for portability (I intend to
backport this as far as I can)

https://github.com/fangq/fedorapkg/commit/e3c77efe03655793e6b263b220caf5296454b919

when I built it on my fc30 vm, it failed with a complain that COPYING was not
found. So, I brought the cp LICENSE.txt COPYING line back. I can make it
conditional if you prefer.


Also, one of the warning messages says "large doc folder". the current
installed doc folder is about 1.1MB, with 80% of those are demo script and
sample data. do you think creating a -doc package is necessary in this case?



@both of you:

since my last package built for fedora was ~10 years ago (using Bohi), my
memory was quite vague now when testing a new package. I was mostly following
this link for new package 

https://fedoraproject.org/wiki/New_package_process_for_existing_contributors

and had the impression that fedpkg can only be called if someone approve this
package first. I tried fedpkg on the fc30 with request-repo and this ticket
number, but it says it was not approved.

other than installing a new vm, are there instructions for testing this package
on rawhide?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux