[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1758036



--- Comment #4 from Kentaro Hayashi <kenhys@xxxxxxxxx> ---
Spec URL: https://packages.groonga.org/tmp/sentencepiece/sentencepiece.spec
SRPM URL:
https://packages.groonga.org/tmp/sentencepiece/sentencepiece-0.1.83-1.fc30.src.rpm
Description: unsupervised text tokenizer for Neural Network-based text
generation

Thank you for review I've fixed spec with feedback comments.

https://bugzilla.redhat.com/show_bug.cgi?id=1758036#c1
https://bugzilla.redhat.com/show_bug.cgi?id=1758036#c2
https://bugzilla.redhat.com/show_bug.cgi?id=1758036#c3

Here is the summary for updates.

* Removed unused Group
* Removed unused ldconfig scriptlet
* Removed needless %defattr, %clean
* Used %make_install, %make_build, %license
* Used %python_provide
* Fixed /usr to %{_prefix}
* Fixed to use -delete in find
* Fixed to unintentional soname bump (less globbing in %files)
* Fixed %description, add missing . in end of sentences

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux