https://bugzilla.redhat.com/show_bug.cgi?id=1758036 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Group: is not used in Fedorba - Not used since Fedora 28: Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig %post libs -p /sbin/ldconfig %postun libs -p /sbin/ldconfig - Not needed: %defattr(-,root,root,-) - make %{?_smp_mflags} → %make_build - make install → %make_install - find %{buildroot} -name '*.a' | xargs rm -f {}\; → find %{buildroot} -name '*.a' -delete - Not needed: %clean - You must install the license file with %license not %doc %files libs %doc README.md %license LICENSE - You must include the python provide macros for your Python package: %package -n python3-%{name} Summary: Python module for SentencePiece %{?python_provide:%python_provide python3-%{name}} See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro - -DCMAKE_INSTALL_PREFIX=%{buildroot}/usr → -DCMAKE_INSTALL_PREFIX=%{buildroot}%{_prefix} You are already a member of the packager group, thus you don't need a sponsor. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
